changelog_from_git_commits fix from command line #12477
Conversation
RishabhTayal
changed the title
|
@joshdholtz This is ready for review. 👀 (getting my emoji game strong 💪 ) 😆 |
| UI.user_error!(":between must be of type array") unless value.kind_of?(Array) | ||
| UI.user_error!(":between must not contain nil values") if value.any?(&:nil?) | ||
| UI.user_error!(":between must be an array of size 2") unless (value || []).size == 2 | ||
| unless value.kind_of?(String) |
There was a problem hiding this comment.
Can we verify if its a string that it has a comma in it?
| @@ -10,7 +10,11 @@ def self.run(params) | |||
| UI.success("Collecting the last #{params[:commits_count]} Git commits") | |||
| else | |||
| if params[:between] | |||
| from, to = params[:between] | |||
| if params[:between].include?(",") # running from shell | |||
There was a problem hiding this comment.
We might need check if its a string here before calling include?
| from, to = params[:between] | ||
| if params[:between].include?(",") # running from shell | ||
| from, to = params[:between].split(",", 2) | ||
| else |
There was a problem hiding this comment.
And depending on how the above is structured.. we may need to add a check to make sure that this is an array?
|
@joshdholtz all the comments are addressed. Ready to review again. 👍 |
|
Just wanted to explain what we are doing here incase. The between option now takes both array of string and string with comma in it. |
|
Nice one @RishabhTayal! |
|
Hey @RishabhTayal 👋 Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉 Please let us know if this change requires an immediate release by adding a comment here 👍 |
fastlane-bot
added
status: released
and removed
status: included-in-next-release
labels
|
Congratulations! 🎉 This was released as part of fastlane 2.96.0 🚀 |
fixes: #10894