Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disables color in xcpretty if env var is set #12519

Merged
merged 1 commit into from May 15, 2018

Conversation

RishabhTayal
Copy link
Contributor

Motivation and Context

Currently snapshot doesn't disables color when export FASTLANE_DISABLE_COLORS=1 is set. This PR will disable the color output.

Description

Before:
screenshot 2018-05-14 12 55 57

After:
screenshot 2018-05-14 12 56 59

Copy link
Collaborator

@revolter revolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@joshdholtz joshdholtz merged commit f4591d0 into fastlane:master May 15, 2018
@RishabhTayal RishabhTayal deleted the snapshot-disable-color-fix branch May 16, 2018 14:53
@fastlane-bot
Copy link

Hey @RishabhTayal 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.96.0 🚀

@fastlane fastlane locked and limited conversation to collaborators Jul 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants