Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[appetize] - fixes crash when url param is given #12544

Merged
merged 1 commit into from May 17, 2018

Conversation

RishabhTayal
Copy link
Contributor

fixes: #11569

Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm after tests that this does fix this 👍 Thank you!

@joshdholtz joshdholtz merged commit 85de141 into fastlane:master May 17, 2018
@fastlane-bot
Copy link

Hey @RishabhTayal 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.96.0 🚀

@RishabhTayal RishabhTayal deleted the appetize-crash-fix branch May 22, 2018 19:32
@fastlane fastlane locked and limited conversation to collaborators Jul 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

undefined method `strip' error when using appetize action with a URL
4 participants