[screengrab] strip whitespace from device_ext_storage to get rid of newline on Windows #13065
Conversation
This comment has been minimized.
This comment has been minimized.
janpio
force-pushed
the
janpio-fix_screengrab_on_windows_2
branch
from
9c93d86
to
83d08bb
Compare
This comment has been minimized.
This comment has been minimized.
screengrab/lib/screengrab/runner.rb
Outdated
| @@ -136,9 +136,10 @@ def screenshot_file_names_in(output_directory, device_type) | |||
| end | |||
|
|
|||
| def determine_external_screenshots_path(device_serial) | |||
| device_ext_storage = run_adb_command("adb -s #{device_serial} shell echo \\$EXTERNAL_STORAGE", | |||
| device_ext_storage = run_adb_command("adb -s #{device_serial} shell echo \$EXTERNAL_STORAGE", | |||
There was a problem hiding this comment.
Commented this on the other PR that this is based off of but just wanted to put this here to so that this doens't accidentally get merged in but \\ is needed on mac 😊
(This will get addressed once rebased after other PR gets merged in to master)
|
@janpio Merged your other PR. Did you want to rebase this one now? |
janpio
force-pushed
the
janpio-fix_screengrab_on_windows_2
branch
from
83d08bb
to
ef45acd
Compare
|
@joshdholtz Rebased and changed PR description. |
|
Hey @janpio 👋 Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉 Please let us know if this change requires an immediate release by adding a comment here 👍 |
fastlane-bot
added
status: released
and removed
status: included-in-next-release
labels
|
Congratulations! 🎉 This was released as part of fastlane 2.102.0 🚀 |
On Windows the executed adb command returns the wanted string - and a newline. To make sure this works everywhere, we
.stripthe string before working with it.closes #13061