iTMSTransporter support on Windows #13148

janpio · 2018-08-17T12:35:48Z

Checklist

I've run bundle exec rspec from the root directory to see all new and existing tests pass
I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
I've read the Contribution Guidelines
I've updated the documentation if necessary.

Motivation and Context

iTMSTransporter is available for Windows, but fastlane's implementation doesn't support it yet.

Description

These commits add support for running fastlane pilot upload / upload_to_testflight and fastlane deliver / upload_to_app_store with binaries on Windows.

If iTMSTransporter is not installed, the tests still pass (as they just generate the command, but don't execute it) but on actual execution of upload_to_testflight or upload_to_app_store you get this error message:

...fastlane/fastlane_core/lib/fastlane_core/ui/interface.rb:141:in `user_error!': [!] Could not find transporter at usual locations. Please use environment variable `FASTLANE_ITUNES_TRANSPORTER_PATH` to specify your installation path. (FastlaneCore::Interface::FastlaneError)

Along the way several smaller bugs in the implementation were fixed and tests added (e.g. for special handling of Xcode >= 9).

joshdholtz

Some small questions and changes

joshdholtz · 2018-08-21T12:03:26Z

fastlane_core/lib/fastlane_core/helper.rb

+        ].each do |path|
+          return path if File.exist?(path)
+        end
+        UI.user_error!("Could not find transporter at usual locations. Please use environment variable `FASTLANE_ITUNES_TRANSPORTER_PATH` to specify your installation path.")
      end


Can we add an else here that does that return ''?

I can see a future issue right now here we get that early return on line 203 with return '' unless self.mac? || self.windows? because something was changed but then this if statement wasn't change and then this bug is hard to track down 😊

That's actually how I already had it in my head when updating this to work on Linux as well, so no problem to already do it now.

joshdholtz · 2018-08-21T12:09:26Z

fastlane_core/lib/fastlane_core/itunes_transporter.rb

          end
        end
      rescue => ex
        @errors << ex.to_s
      end

-      exit_status = $?.exitstatus
-      unless exit_status.zero?
+      if exit_status != 0


Is there a reason for not keeping the user of .zero? here? (and the other spot below)

tbh: I just don't know what exactly .zero does. Is this functionally equivalent?

It is functionally equivalent but its a better way of making sure that we are comparing an number to a number. I would personally keep the .zero? 😊

joshdholtz · 2018-08-21T12:11:17Z

fastlane_core/lib/fastlane_core/itunes_transporter.rb

@@ -187,13 +185,16 @@ def build_download_command(username, password, apple_id, destination = "/tmp", p

    def handle_error(password)
      # rubocop:disable Style/CaseEquality
-      unless password === /^[0-9a-zA-Z\.\$\_]*$/
+      # rubocop:disable Style/YodaCondition
+      unless /^[0-9a-zA-Z\.\$\_\-]*$/ === password


Is there a reason for flopping this comparison around? 🤔

Now it works, before it didn't.
Super strange, seems to have been a bug all along.
@revolter did some experiments on that.

Ah okay. I didn't think there was a difference in what was on left/right side but wasn't sure. So this could be changed back and things would still work the same?

No. If you change it back, it doesn't work. That's the strange thing here.

rubocop actually wants to write it the other way around, which is probably why this was the other way around and didn't work in the first place - I had to add the rubocop:disable Style/YodaCondition to quiet it.

Please feel free to test around a bit yourself with irb, maybe we both missed the point. Very possible.

joshdholtz · 2018-08-21T12:14:06Z

fastlane_core/lib/fastlane_core/itunes_transporter.rb

+        UI.error("")
+        UI.error("Application specific password you provided using")
+        UI.error("environment variable #{TWO_FACTOR_ENV_VARIABLE}")
+        UI.error("is invalid, please make sure it's correct.")


Can you remove the .? Its fastlane style to not add those 😉

Why? I also added the empty line, so it is not as bad any more, but when text continues in the next line, this is just weird, isn't it?

Its just the way things have been generally printed out in the rest of fastlane so would probably like to keep things consistent if possible 😊

joshdholtz · 2018-08-21T12:14:16Z

fastlane_core/lib/fastlane_core/itunes_transporter.rb

      UI.error("Your account has 2 step verification enabled")
      UI.error("Please go to https://appleid.apple.com/account/manage")
      UI.error("and generate an application specific password for")
-      UI.error("the iTunes Transporter, which is used to upload builds")
+      UI.error("the iTunes Transporter, which is used to upload builds.")


Same here with removing the .

joshdholtz · 2018-08-21T12:14:24Z

fastlane_core/lib/fastlane_core/itunes_transporter.rb

      UI.error("To set the application specific password on a CI machine using")
      UI.error("an environment variable, you can set the")
-      UI.error("#{TWO_FACTOR_ENV_VARIABLE} variable")
+      UI.error("#{TWO_FACTOR_ENV_VARIABLE} variable.")


Same here with removing the .

also adapt tests

…ows)

remaining stuff should not block merging any more

(part of it is already in PR #13148)

joshdholtz · 2018-08-28T13:12:39Z

@janpio Can we get a rebase on this since I merged one of your PRs that conflicts with a change in here? 😇

janpio · 2018-08-28T14:08:07Z

Conflict could be solved in GitHub web UI fortunately ;) Still passes @joshdholtz

joshdholtz

Windows support!!! 🙌

janpio · 2018-08-30T14:28:36Z

(One tiny part of it anyway ;))

fastlane-bot · 2018-09-04T19:32:14Z

Congratulations! 🎉 This was released as part of fastlane 2.103.0 🚀

* define path of itms on Windows * define itms_path for Windows (C:/Program Files (x86)/itms) * clean up usage of FastlanePty.spawn * always use shell script on Windows * remove single quotes around the password * fix ipa checksum generation on Windows * fix (single) quote usage on Windows also adapt tests * itms should return directly instead of waiting for key press (on Windows) * don't run itms tests that depend on xcode on platforms without Xcode * new tests with FASTLANE_ITUNES_TRANSPORTER_USE_SHELL_SCRIPT * new test that simulate being on Windows (even when not) * relax password regex as app specific password contain `-` by default * improve error output in case of 2 step verification problems * manual rubocop -a * fix broken exit_status checks * fix broken password check + make rubocop happy * rework tests to work on all OS * move return '' into else for itms_path * rubocop * exit_status == 0 => exit_status.zero? * remove trailing dot in UI output

googlebot added the cla: yes label Aug 17, 2018

janpio changed the title ~~[WIP] itms on windows~~ [WIP] iTMSTransporter support on Windows Aug 17, 2018

janpio force-pushed the janpio-itms_on_windows branch 2 times, most recently from 7c7f6d0 to 54ee627 Compare August 17, 2018 21:27

janpio changed the title ~~[WIP] iTMSTransporter support on Windows~~ iTMSTransporter support on Windows Aug 17, 2018

janpio mentioned this pull request Aug 17, 2018

Fix itms tests on Windows #13000

Closed

4 tasks

joshdholtz previously requested changes Aug 21, 2018

View reviewed changes

janpio and others added 19 commits August 21, 2018 16:41

define path of itms on Windows

01cbd54

define itms_path for Windows (C:/Program Files (x86)/itms)

f5cca54

clean up usage of FastlanePty.spawn

b437b61

always use shell script on Windows

ef79afd

remove single quotes around the password

ff36b3f

fix ipa checksum generation on Windows

93c4444

fix (single) quote usage on Windows

bd527ba

also adapt tests

itms should return directly instead of waiting for key press (on Wind…

48daeef

…ows)

don't run itms tests that depend on xcode on platforms without Xcode

b64919f

new tests with FASTLANE_ITUNES_TRANSPORTER_USE_SHELL_SCRIPT

c72a9e1

new test that simulate being on Windows (even when not)

3234409

relax password regex as app specific password contain - by default

e0748f8

improve error output in case of 2 step verification problems

b31d27f

manual rubocop -a

36dfaf7

fix broken exit_status checks

a3bac1d

fix broken password check + make rubocop happy

2282af6

rework tests to work on all OS

409d007

move return '' into else for itms_path

6c447a1

rubocop

7f0138b

janpio force-pushed the janpio-itms_on_windows branch from 3a824dd to 7f0138b Compare August 21, 2018 14:42

janpio added 2 commits August 21, 2018 19:33

exit_status == 0 => exit_status.zero?

c8464ac

remove trailing dot in UI output

1c3522e

janpio added a commit that referenced this pull request Aug 27, 2018

fix itunes_transporter_spec

c5d0f62

(part of it is already in PR #13148)

Merge branch 'master' into janpio-itms_on_windows

80c639d

joshdholtz approved these changes Aug 30, 2018

View reviewed changes

joshdholtz merged commit 2990de4 into master Aug 30, 2018

joshdholtz deleted the janpio-itms_on_windows branch August 30, 2018 14:18

joshdholtz mentioned this pull request Sep 4, 2018

Version bump to 2.103.0 #13278

Merged

fastlane-bot added the status: released label Sep 4, 2018

janpio mentioned this pull request Sep 5, 2018

[Regression] raise NoMethodError in 2.103.0 when I'm trying to upload ipa with new AppStoreConnect API #13284

Closed

4 tasks

janpio restored the janpio-itms_on_windows branch September 28, 2018 15:47

fastlane locked and limited conversation to collaborators Nov 27, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

iTMSTransporter support on Windows #13148

iTMSTransporter support on Windows #13148

janpio commented Aug 17, 2018 •

edited

joshdholtz left a comment

joshdholtz Aug 21, 2018

janpio Aug 21, 2018

joshdholtz Aug 21, 2018

janpio Aug 21, 2018

joshdholtz Aug 21, 2018

joshdholtz Aug 21, 2018

janpio Aug 21, 2018 •

edited

joshdholtz Aug 21, 2018

janpio Aug 21, 2018 •

edited

joshdholtz Aug 21, 2018

janpio Aug 21, 2018

joshdholtz Aug 21, 2018

janpio Aug 21, 2018

joshdholtz Aug 21, 2018

joshdholtz Aug 21, 2018

joshdholtz commented Aug 28, 2018

janpio commented Aug 28, 2018

joshdholtz left a comment

janpio commented Aug 30, 2018 •

edited

fastlane-bot commented Sep 4, 2018

iTMSTransporter support on Windows #13148

iTMSTransporter support on Windows #13148

Conversation

janpio commented Aug 17, 2018 • edited

Checklist

Motivation and Context

Description

joshdholtz left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

janpio Aug 21, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

janpio Aug 21, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

joshdholtz commented Aug 28, 2018

janpio commented Aug 28, 2018

joshdholtz left a comment

Choose a reason for hiding this comment

janpio commented Aug 30, 2018 • edited

fastlane-bot commented Sep 4, 2018

janpio commented Aug 17, 2018 •

edited

janpio Aug 21, 2018 •

edited

janpio Aug 21, 2018 •

edited

janpio commented Aug 30, 2018 •

edited