Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that changelog input is being requested #13152

Merged
merged 1 commit into from
Aug 21, 2018

Conversation

c0state
Copy link
Contributor

@c0state c0state commented Aug 17, 2018

In the pilot action, when a changelog isn't provided by the user, it is requested on the command line but the wording isn't entirely clear. This change attempts to clarify that the user is being asked for the changelog on the command line.

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

Description

In the pilot action, when a changelog isn't provided by the user, it is requested on the command line but the wording isn't entirely clear. This change attempts to clarify that the user is being asked for the changelog on the command line.
Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this change! This has actually gotten me in the past 😊

@joshdholtz joshdholtz merged commit e0c9e94 into fastlane:master Aug 21, 2018
@fastlane-bot
Copy link

Hey @c0state 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.103.0 🚀

janpio pushed a commit to janpio/fastlane that referenced this pull request Sep 11, 2018
In the pilot action, when a changelog isn't provided by the user, it is requested on the command line but the wording isn't entirely clear. This change attempts to clarify that the user is being asked for the changelog on the command line.
@fastlane fastlane locked and limited conversation to collaborators Nov 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants