Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

measure fastlane startup time via execution time of --help command 🏎️ #13166

Merged
merged 1 commit into from Aug 30, 2018

Conversation

janpio
Copy link
Member

@janpio janpio commented Aug 20, 2018

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

Fastlane can be pretty slow to start. Slow startup is bad.

Description

This PR adds a new lane benchmark_help_command that is also run during execute_tests. It installs a (cross platform) node tool via npm called gnomon that prepends timestamps to lines of out and measures the total execution time. This total is extracted and output in the lane. To make sure we get a good overview, the lane runs fastlane --help 3 times and outputs it runtime.

In the future this lane can be used to benchmark fastlane and that way track and measure the effect of any changes (like #13167).

@janpio janpio mentioned this pull request Aug 20, 2018
4 tasks
@janpio janpio changed the title [WIP] measure execution time of --help command [WIP] measure execution time of --help command 🏎️ Aug 29, 2018
install gnomon if not installed yet
install node if not installed yet
@janpio janpio changed the title [WIP] measure execution time of --help command 🏎️ [lane + tests] measure fastlane startup time via execution time of --help command 🏎️ Aug 29, 2018
@janpio janpio changed the title [lane + tests] measure fastlane startup time via execution time of --help command 🏎️ measure fastlane startup time via execution time of --help command 🏎️ Aug 29, 2018
@joshdholtz joshdholtz merged commit 6d4e157 into master Aug 30, 2018
@joshdholtz joshdholtz deleted the janpio-startup_speed branch August 30, 2018 17:16
janpio added a commit to janpio/fastlane that referenced this pull request Sep 11, 2018
install gnomon if not installed yet
install node if not installed yet
@fastlane fastlane locked and limited conversation to collaborators Oct 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants