[deliver] fix double screenshots directory on deliver setup

[joshdholtz]

Fixes #13194

Problem

The full screenshots path was getting generated here -

fastlane/deliver/lib/deliver/setup.rb

Line 27 in dd0b74f

screenshots_path = options[:screenshots_path] || File.join(deliver_path, 'screenshots')

But then screenshots was getting appended to the path again here -

fastlane/deliver/lib/deliver/setup.rb

Line 130 in dd0b74f

path = File.join(deliver_path, 'screenshots')

Solution

Removed the second screenshots from getting appended in the download_screenshots method

[KrauseFx]

This fixes the newly created screenshots folder, however I have the feeling something else is going wrong here, e.g. #13195.

I'm worried something broke recently (e.g. #13176)

[joshdholtz]

@KrauseFx Aight, I will look into those too 👌

[fastlane-bot]

Hey @joshdholtz 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

[fastlane-bot]

Congratulations! 🎉 This was released as part of fastlane 2.103.0 🚀