[snapshot] added check for missing Snapshot Helper File (#13038) #13205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Awesome! What is missing right now is some instruction on how to do create the file. The best source I could find was https://docs.fastlane.tools/actions/snapshot/#quick-start. Maybe add that (or something better I missed) to the error message? |
|
You're right that's more user friendly. Hope the wording is ok |
joshdholtz
requested changes
Aug 27, 2018
snapshot/lib/snapshot/runner.rb
Outdated
| @@ -122,6 +122,15 @@ def verify_helper_is_current | |||
| UI.verbose("Checking that helper files contain #{current_version}") | |||
|
|
|||
| helper_files = Update.find_helper | |||
| if helper_files.empty? | |||
| UI.error("Your Snapshot Helper file is missing, please place a copy") | |||
| UI.error("in your project directory.") | |||
There was a problem hiding this comment.
Can we remove the "." on this line?
snapshot/lib/snapshot/runner.rb
Outdated
| UI.error("in your project directory.") | ||
| UI.message("More information about Snapshot setup can be found here:") | ||
| UI.message("https://docs.fastlane.tools/actions/snapshot/#quick-start") | ||
| UI.user_error!("Please add a Snapshot Helper file to your project.") |
There was a problem hiding this comment.
Can we also remove the "." on this line?
|
Right 😁 Fixed it now |
joshdholtz
approved these changes
Aug 28, 2018
janpio
pushed a commit
to janpio/fastlane
that referenced
this pull request
Sep 11, 2018
…) (fastlane#13205) * [snapshot] added check for missing Snapshot Helper File (fastlane#13038) * [snapshot] added link to snapshot quick setup in error message (fastlane#13038) * [snapshot] UI formatting (fastlane#13038)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
bundle exec rspecfrom the root directory to see all new and existing tests passbundle exec rubocop -ato ensure the code style is validMotivation and Context
Fixes #13038
Description
Added check for missing Snapshot Helper File. If there is no Snapshot Helper File found, snapshots exits with a descriptive user error.
I tested the fix via manually deleting the Snapshot Helper File from my project and running
fastlane snapshotafterwards.