Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[supply] remove unused CredentialsLoader #13211

Merged
merged 1 commit into from
Aug 27, 2018
Merged

[supply] remove unused CredentialsLoader #13211

merged 1 commit into from
Aug 27, 2018

Conversation

janpio
Copy link
Member

@janpio janpio commented Aug 24, 2018

supply/client was defining CredentialsLoader = Google::Auth::CredentialsLoader which was not used anywhere, so I removed it.

Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this out and seems like everything still works 👍

@joshdholtz joshdholtz merged commit d09ba2f into master Aug 27, 2018
@joshdholtz joshdholtz deleted the janpio-patch-1 branch August 27, 2018 12:59
@fastlane-bot
Copy link

Hey @janpio 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.103.0 🚀

janpio added a commit to janpio/fastlane that referenced this pull request Sep 11, 2018
@fastlane fastlane locked and limited conversation to collaborators Nov 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants