[deliver] make screenshots path relative to Preview.html file #13223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taquitos
reviewed
Aug 28, 2018
| def render_relative_path(export_path, path) | ||
| export_path = Pathname.new(export_path) | ||
| path = Pathname.new(path).relative_path_from(export_path) | ||
| return path.to_path |
joshdholtz
deleted the
joshdholtz-deliver-preview-relative-path-screenshots
branch
|
Congratulations! 🎉 This was released as part of fastlane 2.103.0 🚀 |
janpio
pushed a commit
to janpio/fastlane
that referenced
this pull request
Sep 11, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13176
Problem
The images in
Preview.htmlwere relative on the project root but thePreview.htmlfile is located inside of thefastlanedirectory.Solution
The images (app icon, watch app, and screenshots) get a path that is rendered realtive to the
fastlanedirectory