Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[changelog_from_git_commits] Added quiet parameter #13248

Merged
merged 1 commit into from
Aug 30, 2018
Merged

[changelog_from_git_commits] Added quiet parameter #13248

merged 1 commit into from
Aug 30, 2018

Conversation

Arjan-Zuidema
Copy link
Contributor

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

Fixes: #13240

Description

Added parameter to suppress output. Tested with bundle

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@Arjan-Zuidema
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@janpio janpio changed the title Added quiet parameter [changelog_from_git_commits] Added quiet parameter Aug 30, 2018
Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@joshdholtz joshdholtz merged commit b894478 into fastlane:master Aug 30, 2018
@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.103.0 🚀

@Arjan-Zuidema Arjan-Zuidema deleted the changelog_from_git_commits_quiet branch September 5, 2018 06:31
janpio pushed a commit to janpio/fastlane that referenced this pull request Sep 11, 2018
@fastlane fastlane locked and limited conversation to collaborators Nov 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants