[spaceship] Remove ensure_csrf in 'delete_provisioning_profile!' for more relability

[julianoterres]

Fixed error of token of method 'delete_provisioning_profile!' that was returning the message '765: unexpected token at 'Bad Request''

Checklist

• I've run bundle exec rspec from the root directory to see all new and existing tests pass
• I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
• I've read the Contribution Guidelines
• I've updated the documentation if necessary.

Motivation and Context

Description

closes #13256

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

[googlebot]

CLAs look good, thanks!

[julianoterres]

The error "765: unexpected token at 'Bad Request" was happening bacause the tokens not was sending in header of the post in the method "delete_provisioning_profile!". I saw that the function "repair_provisioning_profile" there were many people complaining the same error. I analyzed the code and I saw that at function "repair_provisioning_profile" removing this part of code bellow:

ensure_csrf(Spaceship::Portal::ProvisioningProfile) do

and this resolved the problem in "repair_provisioning_profile", then I apply the same fix in "delete_provisioning_profile".

[janpio]

So this PR replicates what a different PR did as well? Can you link that PR for reference?

[julianoterres]

@janpio No, I not have the link the PR that fix the function 'repair_provisioning_profile'.

But I analyze the function 'repair_provisioning_profile' and the unique difference between function 'delete_provisioning_profile' and 'repair_provisioning_profile' was that the function 'delete_provisioning_profile' having this code 'ensure_csrf(Spaceship::Portal::ProvisioningProfile) do' and function 'repair_provisioning_profile' not have this code.

After remove this code from function 'delete_provisioning_profile' I tested and the tokens worked.

[joshdholtz]

@julianoterres @janpio Here is the PR that removed this from the repair_provisioning_profile - #11381

It looks like Apple has some limit on calls while the CSRF token is valid, even if those calls are made in different "domains." As a result, call to profile.update! will fail in some conditions. See #11162 for details.

It does look like this is a valid fix but I will do some testing on it before giving the 👍 just to make sure 😊

[joshdholtz]

This looks legit and seems to still work 😊 Thanks for making this fix!

[fastlane-bot]

Hey @julianoterres 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

[fastlane-bot]

Congratulations! 🎉 This was released as part of fastlane 2.103.0 🚀