Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FL_HOCKEY_TIMEOUT fix for "undefined method `zero?'" #13322

Merged
merged 1 commit into from Sep 15, 2018

Conversation

jmihalicza
Copy link
Contributor

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

There was no type specified for FL_HOCKEY_TIMEOUT, and therefore it was passed to faraday as string, causing: undefined method `zero?'

Description

I set the config item type to Integer.
I did not actually test it, but given that the original version leads to undefined method, that path of execution can only become better with the change.

@jmihalicza
Copy link
Contributor Author

@janpio I recreated #13290 in this new PR.

Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This checks out ✅ Thanks for making this fix! ❤️

@joshdholtz joshdholtz merged commit 39f0b0c into fastlane:master Sep 15, 2018
@fastlane-bot
Copy link

Hey @jmihalicza 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.105.0 🚀

@fastlane fastlane locked and limited conversation to collaborators Nov 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants