[WIP] Require relative all the things #13474

milch · 2018-10-01T03:57:04Z

Supersedes #11507

So since I never got around to completing that PR, and rebasing onto master turned out not so well, I just did some magic code copying around from the old branch and re-ran the rubocop I added here.
Did some fix ups as well after, and some smoke testing, which succeeded.

The reason this is still WIP is because

I'd want to do some more testing. If someone has some test projects I'd appreciate if you could run this branch on that and report back with the results. Unfortunately I don't have a test project handy at the moment that I could use
Some work needs to be done to make the Require/MissingRequireStatement rubocop work with the internal references

fastlane-bot-helper · 2018-10-01T03:58:20Z

	2 Warnings
⚠️	Big PR
⚠️	Pull Request is Work in Progress

Generated by 🚫 Danger

milch · 2018-10-01T03:58:51Z

Thank you kind Mr. Bot

googlebot · 2018-10-01T09:01:33Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

janpio · 2018-10-01T09:09:51Z

CI tests are now succeeding again after I pushed a tiny bug fix to your branch.

Will now test it with https://github.com/janpio/fastlane-manual-integration-tests

janpio · 2018-10-02T18:43:11Z

Tested on Windows for typical Android workflow:

fastlane supply init
fastlane screengrab init
gradle
build_android_app
copy_artifacts
fastlane screengrab
capture_android_screenshots
copy_artifacts
fastlane supply
upload_to_play_store

Works as expected.

KrauseFx · 2018-10-02T19:48:10Z

I'm extremely excited about this PR 👍 Thanks @milch for all your hard work on this

janpio · 2018-10-02T21:36:45Z

Do you still see the impressive speed improvements from the original PR @milch?

On CI it seems this branch is a tiny-tiny bit slower than current master.
Of course this doesn't matter as the code is so much better - but I wonder where the improvement went to that you observed on the original PR :/

comparison of `benchmark_help_command` lane for this branch and current `master`

require-relative-best-require:

Ubuntu

[09:02:25]: ---------------------------
[09:02:25]: --- Step: shell command ---
[09:02:25]: ---------------------------
[09:02:27]: 🏎️ 'Total   2.0641s'
[09:02:27]: ---------------------------
[09:02:27]: --- Step: shell command ---
[09:02:27]: ---------------------------
[09:02:30]: 🏎️ 'Total   2.1153s'
[09:02:30]: ---------------------------
[09:02:30]: --- Step: shell command ---
[09:02:30]: ---------------------------
[09:02:32]: 🏎️ 'Total   2.1212s'
[09:02:32]: Turning on FASTLANE_OPTIMIZE_BOOT:
[09:02:32]: ---------------------------
[09:02:32]: --- Step: shell command ---
[09:02:32]: ---------------------------
[09:02:34]: 🏎️ 'Total   2.0655s'
[09:02:34]: ---------------------------
[09:02:34]: --- Step: shell command ---
[09:02:34]: ---------------------------
[09:02:35]: 🏎️ 'Total   0.7875s'
[09:02:35]: ---------------------------
[09:02:35]: --- Step: shell command ---
[09:02:35]: ---------------------------
[09:02:36]: 🏎️ 'Total   0.7456s'
[09:02:36]: Turning off FASTLANE_OPTIMIZE_BOOT again.

macOS

[02:03:34]: ---------------------------
[02:03:34]: --- Step: shell command ---
[02:03:34]: ---------------------------
[02:03:35]: 🏎️ 'Total   1.1140s'
[02:03:35]: ---------------------------
[02:03:35]: --- Step: shell command ---
[02:03:35]: ---------------------------
[02:03:36]: 🏎️ 'Total   1.0749s'
[02:03:36]: ---------------------------
[02:03:36]: --- Step: shell command ---
[02:03:36]: ---------------------------
[02:03:37]: 🏎️ 'Total   1.0862s'
[02:03:37]: Turning on FASTLANE_OPTIMIZE_BOOT:
[02:03:37]: ---------------------------
[02:03:37]: --- Step: shell command ---
[02:03:37]: ---------------------------
[02:03:39]: 🏎️ 'Total   1.5589s'
[02:03:39]: ---------------------------
[02:03:39]: --- Step: shell command ---
[02:03:39]: ---------------------------
[02:03:40]: 🏎️ 'Total   0.5630s'
[02:03:40]: ---------------------------
[02:03:40]: --- Step: shell command ---
[02:03:40]: ---------------------------
[02:03:41]: 🏎️ 'Total   0.5470s'
[02:03:41]: Turning off FASTLANE_OPTIMIZE_BOOT again.

Windows

[09:03:36]: ---------------------------
[09:03:36]: --- Step: shell command ---
[09:03:36]: ---------------------------
[09:03:38]: 🏎️ 'Total   2.3592s'
[09:03:38]: ---------------------------
[09:03:38]: --- Step: shell command ---
[09:03:38]: ---------------------------
[09:03:41]: 🏎️ 'Total   2.4558s'
[09:03:41]: ---------------------------
[09:03:41]: --- Step: shell command ---
[09:03:41]: ---------------------------
[09:03:44]: 🏎️ 'Total   2.3480s'
[09:03:44]: Turning on FASTLANE_OPTIMIZE_BOOT:
[09:03:44]: ---------------------------
[09:03:44]: --- Step: shell command ---
[09:03:44]: ---------------------------
[09:03:47]: 🏎️ 'Total   3.3008s'
[09:03:47]: ---------------------------
[09:03:47]: --- Step: shell command ---
[09:03:47]: ---------------------------
[09:03:50]: 🏎️ 'Total   2.1915s'
[09:03:50]: ---------------------------
[09:03:50]: --- Step: shell command ---
[09:03:50]: ---------------------------
[09:03:52]: 🏎️ 'Total   2.0913s'
[09:03:52]: Turning off FASTLANE_OPTIMIZE_BOOT again.

master:

Ubuntu

[20:38:28]: ---------------------------
[20:38:28]: --- Step: shell command ---
[20:38:28]: ---------------------------
[20:38:31]: 🏎️ 'Total   2.0625s'
[20:38:31]: ---------------------------
[20:38:31]: --- Step: shell command ---
[20:38:31]: ---------------------------
[20:38:33]: 🏎️ 'Total   2.1198s'
[20:38:33]: ---------------------------
[20:38:33]: --- Step: shell command ---
[20:38:33]: ---------------------------
[20:38:35]: 🏎️ 'Total   2.2003s'
[20:38:35]: Turning on FASTLANE_OPTIMIZE_BOOT:
[20:38:35]: ---------------------------
[20:38:35]: --- Step: shell command ---
[20:38:35]: ---------------------------
[20:38:38]: 🏎️ 'Total   2.1139s'
[20:38:38]: ---------------------------
[20:38:38]: --- Step: shell command ---
[20:38:38]: ---------------------------
[20:38:39]: 🏎️ 'Total   0.7423s'
[20:38:39]: ---------------------------
[20:38:39]: --- Step: shell command ---
[20:38:39]: ---------------------------
[20:38:40]: 🏎️ 'Total   0.6707s'
[20:38:40]: Turning off FASTLANE_OPTIMIZE_BOOT again.

macOS

[13:40:31]: ---------------------------
[13:40:31]: --- Step: shell command ---
[13:40:31]: ---------------------------
[13:40:32]: 🏎️ 'Total   1.1720s'
[13:40:32]: ---------------------------
[13:40:32]: --- Step: shell command ---
[13:40:32]: ---------------------------
[13:40:34]: 🏎️ 'Total   1.0534s'
[13:40:34]: ---------------------------
[13:40:34]: --- Step: shell command ---
[13:40:34]: ---------------------------
[13:40:35]: 🏎️ 'Total   1.0748s'
[13:40:35]: Turning on FASTLANE_OPTIMIZE_BOOT:
[13:40:35]: ---------------------------
[13:40:35]: --- Step: shell command ---
[13:40:35]: ---------------------------
[13:40:37]: 🏎️ 'Total   1.6660s'
[13:40:37]: ---------------------------
[13:40:37]: --- Step: shell command ---
[13:40:37]: ---------------------------
[13:40:37]: 🏎️ 'Total   0.5803s'
[13:40:38]: ---------------------------
[13:40:38]: --- Step: shell command ---
[13:40:38]: ---------------------------
[13:40:38]: 🏎️ 'Total   0.5173s'
[13:40:38]: Turning off FASTLANE_OPTIMIZE_BOOT again.

Windows

[20:39:46]: ---------------------------
[20:39:46]: --- Step: shell command ---
[20:39:46]: ---------------------------
[20:39:49]: 🏎️ 'Total   2.3745s'
[20:39:49]: ---------------------------
[20:39:49]: --- Step: shell command ---
[20:39:49]: ---------------------------
[20:39:51]: 🏎️ 'Total   2.4303s'
[20:39:51]: ---------------------------
[20:39:51]: --- Step: shell command ---
[20:39:51]: ---------------------------
[20:39:54]: 🏎️ 'Total   2.2891s'
[20:39:54]: Turning on FASTLANE_OPTIMIZE_BOOT:
[20:39:54]: ---------------------------
[20:39:54]: --- Step: shell command ---
[20:39:54]: ---------------------------
[20:39:58]: 🏎️ 'Total   3.8974s'
[20:39:58]: ---------------------------
[20:39:58]: --- Step: shell command ---
[20:39:58]: ---------------------------
[20:40:01]: 🏎️ 'Total   2.2022s'
[20:40:01]: ---------------------------
[20:40:01]: --- Step: shell command ---
[20:40:01]: ---------------------------
[20:40:03]: 🏎️ 'Total   2.0910s'
[20:40:03]: Turning off FASTLANE_OPTIMIZE_BOOT again.

milch · 2018-10-02T21:44:16Z

@janpio Thanks for your testing!

Most of the replacements from require to require_relative had already been done in a previous PR, so this just completes it for fastlane itself and then automates the process for the future.

One big advantage of this plus the previous work that included the missing require checker should be that you'll be able to require any individual file from fastlane anywhere else and have it work. That'll enable us to go through and remove things like require 'spaceship' and replace it with e.g. require 'spaceship/provisioning_profile' which is where I'd expect big speed improvements to come from

joshdholtz · 2019-02-19T13:31:25Z

@milch Heyyy 👋 Are you still actively working on this one and wanting this merged in? 🙃

janpio · 2019-08-19T10:17:45Z

@mollyIV Are you maybe interested in having another look at the suggested rubocop from this PR and see if this makes sense in the current context and should be re-tried and then merged? Thanks.

janpio · 2020-06-10T19:08:59Z

I feat the failing tests and conflicts are the bigger hurdle here :p

@googlebot I consent.

googlebot · 2020-06-10T19:09:05Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

rogerluan · 2024-01-10T11:46:54Z

Is there still intent to get this moved forward @milch ? At this point sure if it's worth the effort of solving the merge conflicts, or if it'd be better to start over 😅

milch added 4 commits September 30, 2018 19:24

Re-add changes from old branch

02b1821

Run rubocop -a

dee7866

Post rubocop fixups

4365a21

Post rubocop fixups

a0c4630

googlebot added the cla: yes label Oct 1, 2018

milch mentioned this pull request Oct 1, 2018

[WIP] more require work #13458

Closed

4 tasks

Fix ROOT path after moving code from fastlane.rb to fastlane/module.rb

cb624d5

googlebot added cla: no and removed cla: yes labels Oct 1, 2018

fastlane-bot added the status: needs-attention label Oct 15, 2018

janpio added status: wip and removed status: needs-attention labels Nov 13, 2018

fastlane-bot added the status: needs-attention label Nov 14, 2018

googlebot added cla: yes and removed cla: no labels Jun 10, 2020

Cyberbeni mentioned this pull request Jan 29, 2021

[pilot] distribute_only doesn't wait for build processing #18072

Closed

4 tasks

rogerluan added the status: merge conflicts label Dec 27, 2023

rogerluan added tool: cert tool: deliver tool: action tool: fastlane_core tool: frameit labels Dec 27, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] Require relative all the things #13474

[WIP] Require relative all the things #13474

milch commented Oct 1, 2018

fastlane-bot-helper commented Oct 1, 2018

milch commented Oct 1, 2018

googlebot commented Oct 1, 2018

janpio commented Oct 1, 2018

janpio commented Oct 2, 2018

KrauseFx commented Oct 2, 2018

janpio commented Oct 2, 2018 •

edited

Ubuntu

macOS

Windows

Ubuntu

macOS

Windows

milch commented Oct 2, 2018

joshdholtz commented Feb 19, 2019

janpio commented Aug 19, 2019 •

edited

janpio commented Jun 10, 2020

googlebot commented Jun 10, 2020

rogerluan commented Jan 10, 2024

[WIP] Require relative all the things #13474

Are you sure you want to change the base?

[WIP] Require relative all the things #13474

Conversation

milch commented Oct 1, 2018

fastlane-bot-helper commented Oct 1, 2018

milch commented Oct 1, 2018

googlebot commented Oct 1, 2018

janpio commented Oct 1, 2018

janpio commented Oct 2, 2018

KrauseFx commented Oct 2, 2018

janpio commented Oct 2, 2018 • edited

Ubuntu

macOS

Windows

Ubuntu

macOS

Windows

milch commented Oct 2, 2018

joshdholtz commented Feb 19, 2019

janpio commented Aug 19, 2019 • edited

janpio commented Jun 10, 2020

googlebot commented Jun 10, 2020

rogerluan commented Jan 10, 2024

janpio commented Oct 2, 2018 •

edited

janpio commented Aug 19, 2019 •

edited