Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support .gradle.kts project #13672

Merged
merged 1 commit into from Mar 7, 2019
Merged

Support .gradle.kts project #13672

merged 1 commit into from Mar 7, 2019

Conversation

wakwak3125
Copy link
Contributor

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

Currently, we can write Gradle file with Kotlin that file name with .gradle.kts.
But the current version of Fastlane does not support this file type.
To detect the project platform, require the setup.rb should know .gradle.kts is also an Android project.

https://github.com/gradle/kotlin-dsl

Description

I add the line that .kts is also an Android project.
And I test with my .gradle.kts project.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@wakwak3125
Copy link
Contributor Author

CLA signed!

@googlebot
Copy link

CLAs look good, thanks!

@janpio
Copy link
Member

janpio commented Nov 13, 2018

Can you explain a bit what a .gradle.kts actually is? Just a normal .gradle with a different syntax?

@wakwak3125
Copy link
Contributor Author

@janpio
It write with Kotlin.
The normal gradle file write with groovy.

@janpio janpio merged commit 80a5930 into fastlane:master Mar 7, 2019
@janpio
Copy link
Member

janpio commented Mar 7, 2019

Thanks @wakwak3125! Sorry it took so long to merge.

@fastlane-bot
Copy link

Hey @wakwak3125 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.118.0 🚀

@fastlane fastlane locked and limited conversation to collaborators May 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants