Fix support for specifying emulator serial

[raymondhoagland]

Checklist

• I've run bundle exec rspec from the root directory to see all new and existing tests pass
• I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
• I've read the Contribution Guidelines
• I've updated the documentation if necessary.

Motivation and Context

Description

The strip! function that was added in #13846 returns nil if the string was not altered. Ruby docs. The adb action now fails whenever a serial is specified with no implicit conversion of nil into String on line 42 (the Actions.sh call).

Since command is being set with the return value, strip should be used instead which will always return the new value, regardless of whether it was changed.

Can be easily replicated in irb

android_serial = 'emulator-5554'
adb_path = '/test'

command = 'devices'
command = [android_serial, adb_path, command].join(" ").strip!
puts command
# => nil
command = 'devices'
command = [android_serial, adb_path, command].join(" ").strip
puts command
# => emulator-5554 /test devices

[joshdholtz]

Looks good! Thanks for making this fix and writing new tests 😊

[fastlane-bot]

Hey @raymondhoagland 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

[janpio]

Thanks fir fixing my mess @raymondhoagland 🦆

[fastlane-bot]

Congratulations! 🎉 This was released as part of fastlane 2.113.0 🚀