[produce,deliver,spaceship] Support for new AppStore Connect languages: Catalan, Croatian, Czech, Hindi, Hungarian, Polish, Romanian, Slovak, and Ukrainian

[cleanbit]

• New languages:
  Catalan, Croatian, Czech, Hindi, Hungarian, Polish, Romanian, Slovak, and Ukrainian

Checklist

• I've run bundle exec rspec from the root directory to see all new and existing tests pass
• I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
• I've read the Contribution Guidelines
• I've updated the documentation if necessary.

Motivation and Context

New App Store Connect languages were added some time ago and fastlane doesn't support them yet.

Description

Added new language constants and language mappings

---

close #13938

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

[cleanbit]

I signed it!

[googlebot]

CLAs look good, thanks!

[janpio]

Awesome @Zymantas! Where did you get/extract the language codes to add to your files? Anything else worth writing down for future updates of these files?

[cleanbit]

I've taken language codes from the Xcode project localisations (where you add/remove translated languages of your app) and put them here. As I hoped, it worked on both platforms - iOS and macOS! :)

I didn't find anything that's missing with these new languages, but I'll be retesting again when real-world translations will be ready (sometime next week as our translators promised). I'll let you know if this won't be merged till then.

[janpio]

Not on macOS right now, could you maybe post a screenshot of the screen where you got the language codes from? Would appreciate it. Thanks.

[cleanbit]

Also, current fastlane language codes are identical to those in Xcode. So, I suppose all should be fine with the new ones as well.

[joshdholtz]

One small change request! I think 😇

[joshdholtz]

@janpio This can also be achieve by running Spaceship::Tunes.client.available_languages.sort (for getting the language codes at least) 💪 🚀

[janpio]

Nice @joshdholtz - we should add that as a comment in the code where it can be used to "refresh" the list.

[googlebot]

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

[janpio]

Do we maybe also want to add comments that "interlink" these 3 files/locations @joshdholtz? Because if you update one of them, you should always update the others, correct? Can we also add some information in a comment where the other data comes from?

[joshdholtz]

Aye aye! Can do can do 💪

[joshdholtz]

@janpio Updated with more info and link to this PR as an example 😊

[janpio]

Ok, I fixed the comment a bit and added a similar one to the second file.

What about the JSON - we can't just add a comment there :/ What do we do there?

But ohoh, I found another one: https://github.com/fastlane/fastlane/blob/master/spaceship/lib/assets/languageMappingReadable.json

[joshdholtz]

@janpio I did some searching through there and it doens't look like https://github.com/fastlane/fastlane/blob/master/spaceship/lib/assets/languageMappingReadable.json actually gets used anywhere. There are two methods that reference it (from_itc_readable_to_itc and from_itc_to_itc_readable) but these actually don't get referenced anywhere either. I think its okay to not edit this language file and probably also okay to remove that file and those methods in a future PR? 🤔

Also going to ping @KrauseFx since he add this file back in 2015 😉 - fastlane-old/spaceship@dd51003#diff-355ef28abf38992915b1a2e1724703eb

[janpio]

Deleteable code is best code ❌ 💀

[joshdholtz]

Let's ship this 💪

[fastlane-bot]

Hey @Zymantas 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

[max-ott]

@joshdholtz This should be Slovak

[janpio]

Ohoh. Can you please create another PR? Thanks.

[cleanbit]

Ohhh :(. Since this is my PR, I'll create new one with a fix.

[fastlane-bot]

Congratulations! 🎉 This was released as part of fastlane 2.116.1 🚀