Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[action] artifactory: Add a read timeout option #14580

Merged
merged 2 commits into from Apr 17, 2019

Conversation

raymondhoagland
Copy link
Contributor

The Artifactory gem supports a configurable option for the read timeout. The Fastlane action can be extended to pass the argument through to the client.

The default read timeout for the client is 120 so I see no reason to set a different default.

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

Allow configuration of a timeout in case there is a slow connection or other blocker.

Description

This change just adds a new option to set the read timeout for the Artifactory client. This is already a configurable in the underlying gem and will just be passed when initializing the client.

The Artifactory gem supports a configurable option for the read timeout.  The Fastlane action can be extended to pass the argument through to the client.

The [default](https://github.com/chef/artifactory-client/blob/master/lib/artifactory/defaults.rb#L149) read timeout for the client is 120 so I see no reason to set a different default.
@janpio janpio changed the title Add a read timeout option for artifactory [action] artifactory: Add a read timeout option Apr 12, 2019
@janpio
Copy link
Member

janpio commented Apr 12, 2019

The default read timeout for the client is 120 so I see no reason to set a different default.

Couldn't we not define a default to use the gem default?

@raymondhoagland
Copy link
Contributor Author

raymondhoagland commented Apr 12, 2019

Based on this? Yeah that looks right.

Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raymondhoagland This looks good to me! @janpio thanks again for the review while I was away 😍

@joshdholtz joshdholtz merged commit c9d3146 into fastlane:master Apr 17, 2019
@fastlane-bot
Copy link

Hey @raymondhoagland 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.121.0 🚀

@zlobotron
Copy link

Hi
it seems you have missed is_string: false in ConfigItem.new

@fastlane fastlane locked and limited conversation to collaborators Jul 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants