New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[action] artifactory: Add a read timeout option #14580
Conversation
The Artifactory gem supports a configurable option for the read timeout. The Fastlane action can be extended to pass the argument through to the client. The [default](https://github.com/chef/artifactory-client/blob/master/lib/artifactory/defaults.rb#L149) read timeout for the client is 120 so I see no reason to set a different default.
Couldn't we not define a default to use the gem default? |
Based on this? Yeah that looks right. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@raymondhoagland This looks good to me! @janpio thanks again for the review while I was away 😍
Hey @raymondhoagland 👋 Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉 Please let us know if this change requires an immediate release by adding a comment here 👍 |
Congratulations! 🎉 This was released as part of fastlane 2.121.0 🚀 |
Hi |
The Artifactory gem supports a configurable option for the read timeout. The Fastlane action can be extended to pass the argument through to the client.
The default read timeout for the client is 120 so I see no reason to set a different default.
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validMotivation and Context
Allow configuration of a timeout in case there is a slow connection or other blocker.
Description
This change just adds a new option to set the read timeout for the Artifactory client. This is already a configurable in the underlying gem and will just be passed when initializing the client.