Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[frameit] Add missing documentation for title_min_height option #14651

Merged
merged 1 commit into from Apr 23, 2019
Merged

[frameit] Add missing documentation for title_min_height option #14651

merged 1 commit into from Apr 23, 2019

Conversation

bvirlet
Copy link
Contributor

@bvirlet bvirlet commented Apr 23, 2019

No description provided.

@janpio
Copy link
Member

janpio commented Apr 23, 2019

Oh wow, while investigating how this could be missing I found out that the original PR was actually from you @bvirlet! Your original PR also had some documentation: https://github.com/fastlane/fastlane/pull/11014/files#diff-7f11e3a438e137dcda738dc9d59f883eR134

@bvirlet
Copy link
Contributor Author

bvirlet commented Apr 23, 2019

Yes, that PR is a long story 😄

@janpio
Copy link
Member

janpio commented Apr 23, 2019

With this merged it is technically in its third (calendar year) 🚀

@janpio janpio merged commit 56f047f into fastlane:master Apr 23, 2019
@joshdholtz joshdholtz mentioned this pull request Apr 23, 2019
Merged
@fastlane-bot
Copy link

Hey @bvirlet 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

@bvirlet bvirlet deleted the frame-it/add-missing-documentation-on-title_min_height branch April 23, 2019 19:41
@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.121.1 🚀

@fastlane fastlane locked and limited conversation to collaborators Jun 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@janpio janpio janpio approved these changes

Assignees
No one assigned
Labels
cla: yes status: released tool: frameit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bvirlet @janpio @fastlane-bot @googlebot