New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fastlane Swift] Fix suppress_xcode_output parameter type #15152
[Fastlane Swift] Fix suppress_xcode_output parameter type #15152
Conversation
Ping @mollyIV - real Fastlane Swift issue 🙊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably some, going through all of these is kind of busy work though - so we depended on the issues created by users like @jhandguy until now. But if you want to do a sweep of all action options anyway for some reason, go for it! |
Sounds like a good idea 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this! ❤️
Hey @jhandguy 👋 Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉 Please let us know if this change requires an immediate release by adding a comment here 👍 |
Congratulations! 🎉 This was released as part of fastlane 2.129.0 🚀 |
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validMotivation and Context
Generated
Fastlane.swift
includes the wrong type for the argumentsuppressXcodeOutput
, which isString?
instead ofBool?
.Description
Giving implicit
Boolean
type tosuppress_xcode_output
in Ruby solves the issue.