Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fastlane Swift] Fix suppress_xcode_output parameter type #15152

Merged
merged 1 commit into from Aug 13, 2019
Merged

[Fastlane Swift] Fix suppress_xcode_output parameter type #15152

merged 1 commit into from Aug 13, 2019

Conversation

jhandguy
Copy link
Contributor

@jhandguy jhandguy commented Aug 7, 2019

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

Generated Fastlane.swift includes the wrong type for the argument suppressXcodeOutput, which is String? instead of Bool?.

Description

Giving implicit Boolean type to suppress_xcode_output in Ruby solves the issue.

@janpio
Copy link
Member

janpio commented Aug 7, 2019

Ping @mollyIV - real Fastlane Swift issue 🙊

Copy link
Member

@mollyIV mollyIV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jhandguy 👋

Looks good, thank you for fixing this 🙌

I am wondering how many more places like that we have in our codebase? 🤔Maybe we could create a new issue and do the investigation?

CC: @janpio

@janpio
Copy link
Member

janpio commented Aug 7, 2019

Probably some, going through all of these is kind of busy work though - so we depended on the issues created by users like @jhandguy until now. But if you want to do a sweep of all action options anyway for some reason, go for it!

@jhandguy
Copy link
Contributor Author

jhandguy commented Aug 7, 2019

Hey @jhandguy 👋

Looks good, thank you for fixing this 🙌

I am wondering how many more places like that we have in our codebase? 🤔Maybe we could create a new issue and do the investigation?

CC: @janpio

Sounds like a good idea 👍
Let's create an issue for it and make another PR for this, maybe?
I might take a look later! 👌

@joshdholtz
Copy link
Member

@jhandguy @janpio There is already a WIP PR for this that I started a while back (but I bit off more than I could chew) - #13816

It ended up changing too many things to make it a safe merge. I talked with @mollyIV about this and I think we are going to revive this but do it in smaller portions 😊

Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! ❤️

@joshdholtz joshdholtz merged commit b05b6e4 into fastlane:master Aug 13, 2019
@fastlane-bot
Copy link

Hey @jhandguy 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.129.0 🚀

@fastlane fastlane locked and limited conversation to collaborators Oct 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants