New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend update_plist documentation from 1 to 6 code-examples #15861
Extend update_plist documentation from 1 to 6 code-examples #15861
Conversation
It took me some time and trial & error to figure out how to use this action to modify the values inside a plist-file, whose functionality was (imho) only sparsely documented. I added 5 new examples for the basic functionality of this action, in addition to the one (more complicated and highly specific) example already present, to improve understandability and readability in the future. I also slightly adapted the details in order to differentiate this action from the `update_info_plist`action.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm actually really excited about this addition 😊 I always need to look up how I've used this in the past when I want to use it again. Thanks for the contribution ❤️
@joshdholtz Thank you! Super-glad to hear you like it <3 |
Hey @matthiaszarzecki 👋 Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉 Please let us know if this change requires an immediate release by adding a comment here 👍 |
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validMotivation and Context
It took me a considerable amount of time and trial & error to initially figure out how to actually use the
update_plist
action to modify the values inside a plist-file, whose functionality was (imho) only sparsely documented.Description
I added five new examples for the basic functionality of this action in the documentation, in addition to the one (more complicated and highly specific) example already present, to improve understandability and readability in the future.
I also slightly adapted
self.details
in order to differentiate this action from the (similar but different in usage)update_info_plist
action.Testing Steps
In addition to running
bundle exec rspec
andbundle exec rubocop -a
succesfully I tested all of the example-codes and checked the plist-file in XCode afterwards to make sure the values were correctly set. See encompassing testing-code and result-image below: