New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fastlane] migrate from AWS-SDK v2 to AWS-SDK v3 #16143
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
I'm pretty sure tests are green, but not sure why that one failed. Locally everything works. |
Ahh amazing, I've been running around in circles trying to find out why bundler has started getting stuck resolving dependencies. We have a private plugin that is using source 'https://rubygems.org'
gem 'fastlane'
gem 'fastlane-plugin-my_private_plugin' # .gemspec contains `spec.add_dependency 'aws-sdk-s3'` Running I tried using your fork and everything now works again 🙏 Edit: I just read the linked ticket, wish I found that earlier 😅 |
My fork will be removed once that happens, until then feel free to use it. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Let me know @joshdholtz what you think about this, as I mentioned - I think this could be a reason for |
BTW the workaround I suggested in #16130 isn't really ideal in many scenarios since the bloat from the non-modularised version of the v3 SDK is quiet significant... It would be reallllllyyyy awesome if this simple change could make it into the next release 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this! I've pulled this down and tested it with my S3 integration and things seem good 😊 Appreciate the contribution ❤️
Thanks @joshdholtz and @Kaspik for this! 🙏 |
Hey @Kaspik 👋 Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉 Please let us know if this change requires an immediate release by adding a comment here 👍 |
I think it should go sooner than later, and it has been 2 weeks since last release. :) |
@Kaspik Will be making a new release today and keeping up better in the future! My apologies on not getting a release out. Been balancing a lot of stuff lately and I've let things slip 😔 |
Glad to hear that @joshdholtz , thanks! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations! 🎉 This was released as part of fastlane 2.144.0 🚀
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validMotivation and Context
Fixes #16130.
Repairs #15200.
Description
Currently Fastlane uses AWS-SDK v2 and is deprecated.
We could easily migrate to v3 just by changing the version number (via https://docs.aws.amazon.com/sdk-for-ruby/v3/api/ - Upgrade from version 2 -
If you depend on aws-sdk or aws-sdk-resources, you don't need to change anything. Meanwhile we recommend you to revisit following options to explore modularization benefits.
), but because we need only S3 part of the library, and AWS-SDK V3 introduced modularization, it makes sense not to include 200 sub-dependencies, but point only to the required one.Testing Steps
Everything mentioned in Checklist.
Other notes
Introducing AWS-SDK in latest Fastlane causes a lot of issues so I think there should be a minor hotfix release.