Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[supply] Save changelog files as version code instead of version name #16273

Conversation

joshsnelling
Copy link
Contributor

Google Play expects changelog files to be named for the version code to which they will be applied

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

This PR fixes #16253

Description

During supply init/setup, downloaded changelog files are named with the version code instead of the version name of the current release. This makes the downloaded changelog file names consistent with what the supply uploader is expecting when uploading to Google Play.

Testing Steps

These changes were tested with an active Google Play release that only had a single APK (and therefore, only a single version code) assigned to it. In theory, these changes should also work for a release that has multiple APKs assigned to it, but I wasn't able to test this scenario.

Google Play expects changelog files to be named for the version code to which they will be applied
@joshdholtz joshdholtz force-pushed the fix-supply-changelog-file-names-on-init branch from fa2abd9 to b1f2bc4 Compare April 8, 2020 02:38
@janpio janpio added the tool: supply upload_to_playstore label Apr 8, 2020
Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! Thanks for fixing this 😊 I appreciate the contribution ❤️

@joshdholtz joshdholtz merged commit 7d3c943 into fastlane:master Apr 11, 2020
@joshsnelling joshsnelling deleted the fix-supply-changelog-file-names-on-init branch April 11, 2020 15:09
@fastlane-bot
Copy link

Hey @joshsnelling 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

Copy link

@fastlane-bot fastlane-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations! 🎉 This was released as part of fastlane 2.146.0 🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[supply] Mismatch between expected changelog file names in supply setup vs supply uploader
5 participants