New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding --port setter to socket_server #16381
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
fwiw circleci says the fastlane.swift test (marked as pending on GH) is green |
Hey @rhdeck 👋 Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉 Please let us know if this change requires an immediate release by adding a comment here 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations! 🎉 This was released as part of fastlane 2.147.0 🚀
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validMotivation and Context
Right now, except for swift lanes, one cannot (without additional ruby code) run multiple fastlane socket server sessions. This would be really nice for parallelization, as well as for environments where localhost:2000 is otherwise spoken for.
Description
The
start_server
action gains an additional, optional parameter:-p port
. This option (documented in the action itself) sets the port on localhost on which to mount the socket server. Takes four lines of code.Testing Steps
fastlane action start_server -p 2001 & nc localhost 2001
Happy connecting!
NB This change just adds three lines of code - it's a small change to open up a lot of power.