Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding --port setter to socket_server #16381

Merged
merged 2 commits into from May 2, 2020
Merged

Conversation

rhdeck
Copy link
Contributor

@rhdeck rhdeck commented Apr 25, 2020

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

Right now, except for swift lanes, one cannot (without additional ruby code) run multiple fastlane socket server sessions. This would be really nice for parallelization, as well as for environments where localhost:2000 is otherwise spoken for.

Description

The start_server action gains an additional, optional parameter: -p port. This option (documented in the action itself) sets the port on localhost on which to mount the socket server. Takes four lines of code.

Testing Steps

fastlane action start_server -p 2001 &
nc localhost 2001

Happy connecting!

NB This change just adds three lines of code - it's a small change to open up a lot of power.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@rhdeck
Copy link
Contributor Author

rhdeck commented Apr 25, 2020

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@rhdeck
Copy link
Contributor Author

rhdeck commented Apr 29, 2020

fwiw circleci says the fastlane.swift test (marked as pending on GH) is green

@janpio janpio merged commit a77af1a into fastlane:master May 2, 2020
@fastlane-bot
Copy link

Hey @rhdeck 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

Copy link

@fastlane-bot fastlane-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations! 🎉 This was released as part of fastlane 2.147.0 🚀

@fastlane fastlane locked and limited conversation to collaborators Jul 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants