Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fastlane] Extend socket failure payload #16632

Merged
merged 8 commits into from
Jul 6, 2020
Merged

[fastlane] Extend socket failure payload #16632

Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6f719b8
Adding port setter to action interface of socket_server
rhdeck Apr 25, 2020
e0b904e
Trailing whitespace caused lint failure
rhdeck Apr 25, 2020
090964b
Merge remote-tracking branch 'upstream/master' into set_socket_port
rhdeck Jun 19, 2020
faa9d35
Merge remote-tracking branch 'upstream/master' into extend_socket_error
rhdeck Jun 19, 2020
fdf53bb
Adding error detail for socket server
rhdeck Jun 19, 2020
94ca211
Fixing trailing whitespace
rhdeck Jun 19, 2020
bc373e7
Clearing blank spaces from blank line (thank you rubocop)
rhdeck Jun 19, 2020
8c79373
Merge remote-tracking branch 'upstream/master' into extend_socket_error
rhdeck Jun 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 7 additions & 1 deletion fastlane/lib/fastlane/server/socket_server.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,10 @@ def execute_action_command(command: nil)
exception_array << "#{e.class}:"
exception_array << e.backtrace

ec = e.class

em = e.message

while e.respond_to?("cause") && (e = e.cause)
exception_array << "cause: #{e.class}"
exception_array << e.backtrace
Expand All @@ -223,7 +227,9 @@ def execute_action_command(command: nil)
payload = {
payload: {
status: "failure",
failure_information: exception_array.flatten
failure_information: exception_array.flatten,
failure_class: ec,
failure_message: em
}
}
return JSON.generate(payload)
Expand Down