[fastlane-core] Require rubyzip >= 2.0.0 #16660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just saw #15970 (comment). @joshdholtz, do you want me to make it |
|
Yes please! |
2.x fixes some bugs and also supports only Ruby 2.4 and above, like fastlane. `Zip.validate_entry_sizes = true` was removed because it's the default in rubyzip 2.x. https://github.com/rubyzip/rubyzip/blob/v2.3.0/rubyzip.gemspec#L23 https://github.com/rubyzip/rubyzip/blob/v2.3.0/Changelog.md https://github.com/rubyzip/rubyzip/blob/v2.3.0/Changelog.md#130-2019-09-25 https://github.com/fastlane/fastlane/blob/2.150.0.rc1/fastlane_core/lib/fastlane_core/ipa_file_analyser.rb#L40
aried3r
force-pushed
the
ar/loosen_rubyzip_dependency
branch
from
6c06b90
to
4c942bb
Compare
aried3r
changed the title
|
Done. |
janpio
approved these changes
Jun 28, 2020
4 tasks
|
Thanks. |
|
Hey @aried3r 👋 Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉 Please let us know if this change requires an immediate release by adding a comment here 👍 |
fastlane-bot
reviewed
Jul 1, 2020
There was a problem hiding this comment.
Congratulations! 🎉 This was released as part of fastlane 2.150.0 🚀
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
bundle exec rspecfrom the root directory to see all new and existing tests passbundle exec rubocop -ato ensure the code style is validMotivation and Context
2.x fixes some bugs and also supports only Ruby 2.4 and above, like fastlane.
Zip.validate_entry_sizes = truewas removed because it's the default in rubyzip 2.x.https://github.com/rubyzip/rubyzip/blob/v2.3.0/rubyzip.gemspec#L23
https://github.com/rubyzip/rubyzip/blob/v2.3.0/Changelog.md
https://github.com/rubyzip/rubyzip/blob/v2.3.0/Changelog.md#130-2019-09-25
https://github.com/fastlane/fastlane/blob/2.150.0.rc1/fastlane_core/lib/fastlane_core/ipa_file_analyser.rb#L40
Edit:
Related PRs:
#16072
#15970
Description
The only direct usage of
rubyzipI could find was inipa_file_analyzer.rb, I did not find any usage that should break with this change.Testing Steps
Ran all specs and especially the
ipd_file_analyzer_specs.rb, which pass withrubyzip2.3.