Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[deliver] set type of auto release date to integer #16767

Merged
merged 2 commits into from
Jul 7, 2020
Merged

[deliver] set type of auto release date to integer #16767

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c305188
[deliver] set type of auto release date to integer
Jul 6, 2020
d6c78d3
Add validation to make sure auto_release_date is greater than now in ms
Jul 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion deliver/lib/deliver/options.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,11 +165,17 @@ def self.available_options
FastlaneCore::ConfigItem.new(key: :auto_release_date,
env_name: "DELIVER_AUTO_RELEASE_DATE",
description: "Date in milliseconds for automatically releasing on pending approval (Can not be used together with `automatic_release`)",
is_string: false,
type: Integer,
optional: true,
conflicting_options: [:automatic_release],
conflict_block: proc do |value|
UI.user_error!("You can't use 'auto_release_date' and '#{value.key}' options together.")
end,
verify_block: proc do |value|
now_in_ms = Time.now.to_i * 1000
if value < now_in_ms
UI.user_error!("'#{value}' needs to be in the future and in milliseonds (current time is '#{now_in_ms}')")
end
end),
FastlaneCore::ConfigItem.new(key: :phased_release,
env_name: "DELIVER_PHASED_RELEASE",
Expand Down