Allows user not to clean on ipa command

[ashfurrow]

Shenzhen cleans by default unless you specify the --no-clean flag. This is a problem, since some projects (ours) cannot be successfully compiled on a clean build.

The way the ipa command was set up lead to basically no being able to opt out of the default clean.

There's probably a lot better way to do this, both syntactically and from a "this is terrible code" perspective. I couldn't figure out how to use clean: false or something equivalent, but would be happy to do so given a point in the right direction.

Also I can add tests of course, when we get the implementation down.

[KrauseFx]

Makes sense, it's okay to add it like this. If you could add a test for it, it's ready to merge 👍

[ashfurrow]

Sounds good – I'll add a test.

It does feel a bit unnatural though. Would it be better to have a clean value that is true by default?

[KrauseFx]

Yes, probably! Let's go with that.

[ashfurrow]

OK cool. I'll come up with an implementation I think make sense and some tests.

[KrauseFx]

Thanks @ashfurrow for working on this 👍

[ashfurrow]

No problem! Before I write any tests, does this implementation make sense? Any suggestions on its style? Couldn't figure out how to switch between two different args depending on the value of the param.

[KrauseFx]

Yes, it looks good. I honestly don't like the style of this part of the code in general (not yours, the code as it was before), as it's not very clear what part is being used.

If it works, I'm okay with it 👍

[ashfurrow]

OK cool. I'll write a test, then!

[ashfurrow]

OK coo, this is tested.

Users providing the old clean: nil argument will need to change. I can add a check for v.nil? for backwards compatibility. Just let me know.

[joshdholtz]

Looks good to me 👍

[KrauseFx]

Thanks again @ashfurrow 🚀

[KrauseFx]

This will be in the next release, please use the latest version from the master branch for now.

[ashfurrow]

Coooool will do!