New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[spaceship] add shortcuts for getting current pending release and current in review app store version #16808
[spaceship] add shortcuts for getting current pending release and current in review app store version #16808
Conversation
…ew app store version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding these! Just a small request to remove the array and join that isn’t needed 😊
@joshdholtz Done! I also removed the join from the ready for sale version as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! Thank you for adding this and making my requested changes ❤️ Really appreciate the contribution!
Hey @addbrick 👋 Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉 Please let us know if this change requires an immediate release by adding a comment here 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations! 🎉 This was released as part of fastlane 2.154.0 🚀
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validMotivation and Context
This adds short cuts for getting the app store version which is In Review via
get_in_review_app_store_version
, and Pending Developer Release viaget_pending_release_app_store_version
. This way I don't have to remember the filters when looking these versions up.Description
This adds short cuts for getting the app store version which is In Review via
get_in_review_app_store_version
, and Pending Developer Release viaget_pending_release_app_store_version
.Testing Steps