Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[spaceship] add shortcuts for getting current pending release and current in review app store version #16808

Merged
merged 2 commits into from Jul 28, 2020

Conversation

addbrick
Copy link
Contributor

@addbrick addbrick commented Jul 9, 2020

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

This adds short cuts for getting the app store version which is In Review via get_in_review_app_store_version, and Pending Developer Release via get_pending_release_app_store_version. This way I don't have to remember the filters when looking these versions up.

Description

This adds short cuts for getting the app store version which is In Review via get_in_review_app_store_version, and Pending Developer Release via get_pending_release_app_store_version.

Testing Steps

@joshdholtz joshdholtz changed the title add shortcuts for getting current pending release and current in revi… [spaceship] add shortcuts for getting current pending release and current in revi… Jul 9, 2020
Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these! Just a small request to remove the array and join that isn’t needed 😊

spaceship/lib/spaceship/connect_api/models/app.rb Outdated Show resolved Hide resolved
spaceship/lib/spaceship/connect_api/models/app.rb Outdated Show resolved Hide resolved
@addbrick
Copy link
Contributor Author

@joshdholtz Done! I also removed the join from the ready for sale version as well.

Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thank you for adding this and making my requested changes ❤️ Really appreciate the contribution!

@joshdholtz joshdholtz merged commit b0ad150 into fastlane:master Jul 28, 2020
@joshdholtz joshdholtz changed the title [spaceship] add shortcuts for getting current pending release and current in revi… [spaceship] add shortcuts for getting current pending release and current in review app store version Jul 28, 2020
@fastlane-bot
Copy link

Hey @addbrick 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

Copy link

@fastlane-bot fastlane-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations! 🎉 This was released as part of fastlane 2.154.0 🚀

@fastlane fastlane locked and limited conversation to collaborators Sep 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants