Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update webmock, faraday #16853

Merged
merged 2 commits into from
Jul 16, 2020
Merged

Update webmock, faraday #16853

merged 2 commits into from
Jul 16, 2020

Conversation

aried3r
Copy link
Contributor

@aried3r aried3r commented Jul 14, 2020

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

Keep dependencies up to date. Using a newer webmock, we can also use a newer faraday version.

Description

Because of lostisland/faraday#1084 the stubs had to be modified. Alternatively, we could filter out blank parameters so they don't show up in the resulting URL. Or the tests could stop calling it with an empty array and instead pass nil, then we could call .compact or let faraday handle it.

params = {
teamId: team_id,
provisioningProfileName: name,
appIdId: app_id,
distributionType: distribution_method,
certificateIds: certificate_ids,
deviceIds: device_ids
}

response = subject.create_provisioning_profile!("net.sunapps.106 limited", "limited", 'R9YNDTPLJX', ['C8DL7464RQ'], [], mac: false, sub_platform: nil, template_name: template_name)

Updating webmock to 3.x made it possible to use faraday 1.x.

Faraday corrected a bug in handling empty arrays in params, hence the
necessary changes in the stubbing. See:
lostisland/faraday#1084
Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me! Thanks for updating these 😊 Appreciate the contribution ❤️

@joshdholtz joshdholtz merged commit a68011c into fastlane:master Jul 16, 2020
@fastlane-bot
Copy link

Hey @aried3r 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

minuscorp pushed a commit to minuscorp/fastlane that referenced this pull request Jul 18, 2020
* [fastlane] Update webmock to 3.8

Changelog:
https://github.com/bblimke/webmock/blob/v3.8.3/CHANGELOG.md

SemVer stability:
https://dependabot.com/compatibility-score.html/?dependency-name=webmock&package-manager=bundler&version-scheme=semver

* [fastlane] Update faraday to 1.x

Updating webmock to 3.x made it possible to use faraday 1.x.

Faraday corrected a bug in handling empty arrays in params, hence the
necessary changes in the stubbing. See:
lostisland/faraday#1084
@fastlane fastlane locked and limited conversation to collaborators Sep 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants