Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validMotivation and Context
Keep dependencies up to date. Using a newer webmock, we can also use a newer faraday version.
Description
Because of lostisland/faraday#1084 the stubs had to be modified. Alternatively, we could filter out blank parameters so they don't show up in the resulting URL. Or the tests could stop calling it with an empty array and instead pass
nil
, then we could call.compact
or let faraday handle it.fastlane/spaceship/lib/spaceship/portal/portal_client.rb
Lines 689 to 696 in 4342b00
fastlane/spaceship/spec/portal/portal_client_spec.rb
Line 288 in 4342b00