Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deliver] fetches app with Spaceship::ConnectAPI #16857

Merged

Conversation

joshdholtz
Copy link
Member

@joshdholtz joshdholtz commented Jul 14, 2020

Motivation and Context

Fixes #16823

Description

  • Replaces Spaceship::Tunes::Application.find with Spaceship::ConnectAPI equivalents
  • Rewrote Deliver::Setup to use Spaceship::ConnectAPI
  • Uncommented deliver/setup_spec.rb

@joshdholtz joshdholtz merged commit 666c91b into master Jul 16, 2020
@joshdholtz joshdholtz deleted the joshdholtz-deliver-remove-fetch-app-with-spaceship-tunes branch July 16, 2020 16:34
@fastlane-bot
Copy link

Hey @joshdholtz 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

minuscorp pushed a commit to minuscorp/fastlane that referenced this pull request Jul 18, 2020
* [deliver] fetches app with Spaceship::ConnectAPI

* Start of rewrite download meta and setup tests

* Download metadata is now updated

* Fully updated deliver setup spec

* Update doc

* Fix some broken tests

* Add tests for setup categories

* Fixed some more stuff
Copy link

@fastlane-bot fastlane-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations! 🎉 This was released as part of fastlane 2.153.0 🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spaceship::Tunes::Application.all doesn't contain newly created iOS app, preventing build upload
3 participants