Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --use-netrc option to carthage action #16942

Merged
merged 2 commits into from Jul 28, 2020

Conversation

tattn
Copy link
Contributor

@tattn tattn commented Jul 27, 2020

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

Carthage has --use-netrc option. (Carthage/Carthage#2774)
But the carthage action is not supported for the option.

Description

I added use-netrc option to carthage action.
And I added the test.

Testing Steps

I tried the option locally. It was successful.

carthage(platform: 'iOS', use_netrc: true)
[13:17:41]: ----------------------
[13:17:41]: --- Step: carthage ---
[13:17:41]: ----------------------
[13:17:41]: $ carthage bootstrap --use-netrc --platform iOS

Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me! Thanks for adding this in ❤️ Really appreciate the contribution!

@joshdholtz joshdholtz merged commit f86a5bc into fastlane:master Jul 28, 2020
@tattn tattn deleted the add-carthage-netrc branch July 28, 2020 14:00
@fastlane-bot
Copy link

Hey @tattn 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

Copy link

@fastlane-bot fastlane-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations! 🎉 This was released as part of fastlane 2.154.0 🚀

@fastlane fastlane locked and limited conversation to collaborators Sep 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants