[deliver] Fixed filename for review information of AppStoreConnect

[ha1f]

Checklist

• I've run bundle exec rspec from the root directory to see all new and existing tests pass
• I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
• I've read the Contribution Guidelines
• I've updated the documentation if necessary.

Motivation and Context

As for upload_to_app_store docs, I guess filename for "Review Information Metadata" is wrong.

Description

I changed filename for doc to match the implementation.

Since we use key of UploadMetadata::REVIEW_INFORMATION_VALUES_LEGACY for its filename here.

fastlane/deliver/lib/deliver/setup.rb

Line 142 in a68011c

resulting_path = File.join(base_dir, "#{file_key}.txt")

I'm not sure which is wrong, generate path or docs.
If I have to change generate function instead, I'll implement it.

Testing Steps

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[ha1f]

@googlebot I signed it!

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[joshdholtz]

@ha1f Oh no! I hope I didn’t introduce a breaking change on accident 😱 What file names were you using? Were you using review_first_name and review_last_name?

[ha1f]

@joshdholtz I'm sorry, but we didn't use the files so far.

I just found that doc says "first_name.txt", though download_metadata produces "review_first_name.txt".

I read some code, but I couldn't find which is correct in a meantime.

[joshdholtz]

@ha1f Ohhhhhh, I see I see! Are you cool if I add on to this PR? 😊 I think I want to keep the docs the way they are. Download meta I think I want to produce first_name (not review_first_name) but I also need to add back support review_first_name 😇

I didn’t realize this got messed up 😱

[ha1f]

Oh, I see!

Of course, thanks for your help!

[googlebot]

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

[joshdholtz]

@googlebot I consent.

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[joshdholtz]

@ha1f I added my commit! Would you mind reviewing my changes if you have time? 😇

[joshdholtz]

Thanks so much for catching this issue and starting this PR! Really appreciate the contribution ❤️

[fastlane-bot]

Congratulations! 🎉 This was released as part of fastlane 2.154.0 🚀

[ha1f]

Good morning (from Japan).

Thank you so much @joshdholtz !