[screengrab] Permission Issues on API > 21

[Gregadeaux]

Checklist

• I've run bundle exec rspec from the root directory to see all new and existing tests pass
• I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
• I've read the Contribution Guidelines
• I've updated the documentation if necessary.

Motivation and Context

Fixes #15788

Description

Added run-as to commands that are accessing the possible screenshots directories to avoid permission failures. Created an empty Android project using the "Basic Activity" template. Implemented the test case described in the Screenshots documentation that takes two screenshots. Tested on 2 emulators, one running Android 21 and one running Android 28.

Testing Steps

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[Gregadeaux]

@googlebot I signed it!

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[rogerluan]

This is a great fix! Clean solution for a problem affecting multiple users for a long time 💪

[joshdholtz]

This is 🔥 Thanks, Greg! ❤️ You my hero

[fastlane-bot]

Hey @Gregadeaux 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

[fastlane-bot]

Congratulations! 🎉 This was released as part of fastlane 2.156.0 🚀

[Thangaraj-M]

@Gregadeaux @joshdholtz
Due to this change, there was error occurred when clearing existing screenshots in the device. So the screenshot taken in the previous run of same app is remain exist and those screenshots also pulled at the time of second run. Can you please check this?

It is occurred when using the device with API level 24

Error log is below
INFO [2020-08-31 14:25:22.87]: Cleaning screenshots on device
INFO [2020-08-31 14:25:22.90]: ▸ �[35mrun-as: Package '' is unknown�[0m
run-as: Package '' is unknown
ERROR [2020-08-31 14:25:22.90]: �[31mExit status: 254�[0m
INFO [2020-08-31 14:25:22.92]: ▸ �[35mrun-as: Package '' is unknown�[0m
run-as: Package '' is unknown
ERROR [2020-08-31 14:25:22.92]: �[31mExit status: 254�[0m
INFO [2020-08-31 14:25:22.94]: ▸ �[35mrun-as: Package '' is unknown�[0m
run-as: Package '' is unknown
ERROR [2020-08-31 14:25:22.94]: �[31mExit status: 254�[0m
INFO [2020-08-31 14:25:22.97]: ▸ �[35mrun-as: Package '' is unknown�[0m
run-as: Package '' is unknown
ERROR [2020-08-31 14:25:22.97]: �[31mExit status: 254�[0m
INFO [2020-08-31 14:25:22.99]: ▸ �[35mrun-as: Package '' is unknown�[0m
run-as: Package '' is unknown
ERROR [2020-08-31 14:25:23.00]: �[31mExit status: 254�[0m

[joshdholtz]

@Thangaraj-M Do you mind create a new separate issue for this so that we can track the fix separately? 😊 Thank you!

[Thangaraj-M]

@joshdholtz I have created new issue for this. #17119