[spaceship] automatically select Spaceship::Portal or Spaceship::Tunes team if env is set when logging into Spaceship:: ConnectAPI #17136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 2, 2020 13:49
…s team if env is set when logging into Spaceship::ConnectAPI
joshdholtz
force-pushed
the
joshdholtz-spaceship-prevent-warning-about-multiple-times
branch
from
7eecd8b
to
56cb995
Compare
joshdholtz
deleted the
joshdholtz-spaceship-prevent-warning-about-multiple-times
branch
4 tasks
|
Hey @joshdholtz 👋 Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉 Please let us know if this change requires an immediate release by adding a comment here 👍 |
fastlane-bot
reviewed
Sep 4, 2020
There was a problem hiding this comment.
Congratulations! 🎉 This was released as part of fastlane 2.157.3 🚀
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Fixes #17125
Description
client.team_idwas being called when being set into theSpaceship::ConnectAPI::Clientselect_teamcalls were happening right away but this still shouldn’t get printed out to usersselect_teamto happen inloginby looking for ENVsselect_team