Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deliver] read values from SharedValues context only if needed #17616

Merged
merged 1 commit into from Nov 18, 2020

Conversation

rogerluan
Copy link
Member

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

Resolves #17593

Description

Code is pretty straight forward, the values were being overridden by the shared values context instead of using a ||= operator (i.e. "assign if needed").

Testing Steps

This PR was tested against the test case described in #17593.

To test this branch, modify your Gemfile as:

gem "fastlane", :git => "https://github.com/fastlane/fastlane.git", :branch => "rogerluan-prefer-deliver-inline-option"

@stocc
Copy link

stocc commented Nov 16, 2020

Hi, thanks for the fix!
Happy to report it works great, also in my main Fastfile 🎉

Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh my goodness! I can't believe it wasn't already like this 😱 Thanks for catching this! Really appreciate the contribution ❤️

@joshdholtz joshdholtz merged commit 13ed3bd into master Nov 18, 2020
@joshdholtz joshdholtz deleted the rogerluan-prefer-deliver-inline-option branch November 18, 2020 19:49
@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.168.0 🚀

@fastlane fastlane locked and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deliver uses SharedValues::IPA_OUTPUT_PATH instead of specified ipa option
4 participants