New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[onesignal]Update onesignal.rb to include optional organization_id #17696
Conversation
adds optional, organization_id, paramater to onesignal.rb
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! Just a few small requests 😊
Co-authored-by: Josh Holtz <josh@rokkincat.com>
Co-authored-by: Josh Holtz <josh@rokkincat.com>
Co-authored-by: Josh Holtz <josh@rokkincat.com>
Updated with your suggestions. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thank you so much for the contribution ❤
Hey @brandon-carpenter 👋 Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉 Please let us know if this change requires an immediate release by adding a comment here 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations! 🎉 This was released as part of fastlane 2.170.0 🚀
🔑 adds optional, organization_id, paramater to onesignal.rb
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validMotivation and Context
This change adds the Onesignal organization_id as an optional parameter. Presently, when new Onesignal applications are created, they are created without being assigned to an organization. This allows end users to specify an organization_id if desired. Apps created under an organization will delegate the Onesignal org-level-admins to that application. Org-level-admins are unable to view/modify apps not within the organization.
No issue has been created. Please let me know if you'd like an issue created for this PR.
Description
The additional parameter was added inline with the other parameters in onesignal.rb. Payload has been updated along with self.available_options, and self.example_code.
Both
bundle exec rubocop -a
andbundle exec rspec
as referenced here were ran following the changes.Testing Steps
bundle exec onesignal
was ran with a Fastfile containing the necessary parameters includingorganization_id
. This resulted in a new application being created within Onesignal under the provided organization_id. This allowed org-level-admins to view the newly created onesignal application. Additionally, the changes were ran on an app update successfully, and on an app without the organization_id provided. On the latter, the app was created without being assigned to an organization. The changes will also update an application that was created outside of an organization and will move it under the provided organization.