-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gym][scan][snapshot] disable automatic SPM dependencies resolution or skip it entirely #17916
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @RomanTysiachnik 👋
First of all, thank you so much for this awesome contribution! ❤️
The overall logic of your PR looks solid. I left some comments about code style/syntax sugar, and also usability improvements 🙏
This feature will certainly provide a lot of value to users, since it will enable much faster builds! 🚀 thanks once again for taking the initiative!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Thanks for all the changes 🚀
@rogerluan is it ready to be merged? :) |
It still needs a final ✅ from @joshdholtz, @RomanTysiachnik 🙇 thanks for your understanding 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me! Really appreciate the contribution ❤️
Hey @RomanTysiachnik 👋 Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉 Please let us know if this change requires an immediate release by adding a comment here 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations! 🎉 This was released as part of fastlane 2.172.0 🚀
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validMotivation and Context
Resolves #17628
The goal is to allow devs to manually handle SPM dependencies using
xcodebuild
command on the CI. Which is why it is now possible to skip gym's step that resolves package dependencies.Also added an argument that prevents
xcodebuild
from fetching unexpected versions of Swift packages and will only get revisions that are stored inPackage.resolved
file.Description
disable_automatic_package_resolution
argument to resolve only those packages that are specified inPackage.resolved
fileskip_resolve_package_dependencies
argument to skip manualxcodebuild -resolvePackageDependencies
command.