Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gym][scan][snapshot] disable automatic SPM dependencies resolution or skip it entirely #17916

Merged
merged 2 commits into from
Jan 15, 2021

Conversation

balavor
Copy link
Contributor

@balavor balavor commented Jan 7, 2021

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

Resolves #17628

The goal is to allow devs to manually handle SPM dependencies using xcodebuild command on the CI. Which is why it is now possible to skip gym's step that resolves package dependencies.
Also added an argument that prevents xcodebuild from fetching unexpected versions of Swift packages and will only get revisions that are stored in Package.resolved file.

Description

  • Added disable_automatic_package_resolution argument to resolve only those packages that are specified in Package.resolved file
  • Added skip_resolve_package_dependencies argument to skip manual xcodebuild -resolvePackageDependencies command.

@google-cla

This comment has been minimized.

@google-cla

This comment has been minimized.

2 similar comments
@google-cla

This comment has been minimized.

@google-cla

This comment has been minimized.

@google-cla google-cla bot added cla: yes and removed cla: no labels Jan 7, 2021
@balavor balavor changed the title Added skip_resolve_package_dependencies arg to disable SPM dependencies resoultion Added arg to disable automatic SPM dependencies resolution Jan 7, 2021
@balavor balavor changed the title Added arg to disable automatic SPM dependencies resolution [xcodebuild] Disable automatic SPM dependencies resolution or skip it entirely Jan 9, 2021
Copy link
Member

@rogerluan rogerluan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @RomanTysiachnik 👋

First of all, thank you so much for this awesome contribution! ❤️

The overall logic of your PR looks solid. I left some comments about code style/syntax sugar, and also usability improvements 🙏

This feature will certainly provide a lot of value to users, since it will enable much faster builds! 🚀 thanks once again for taking the initiative!

fastlane/swift/Fastlane.swift Outdated Show resolved Hide resolved
fastlane_core/lib/fastlane_core/project.rb Outdated Show resolved Hide resolved
fastlane_core/lib/fastlane_core/project.rb Outdated Show resolved Hide resolved
fastlane_core/lib/fastlane_core/project.rb Outdated Show resolved Hide resolved
fastlane_core/lib/fastlane_core/project.rb Outdated Show resolved Hide resolved
gym/lib/gym/options.rb Outdated Show resolved Hide resolved
fastlane_core/spec/project_spec.rb Outdated Show resolved Hide resolved
@rogerluan rogerluan changed the title [xcodebuild] Disable automatic SPM dependencies resolution or skip it entirely [gym][scan][snapshot] disable automatic SPM dependencies resolution or skip it entirely Jan 10, 2021
@balavor
Copy link
Contributor Author

balavor commented Jan 10, 2021

@rogerluan

  • Updated naming;
  • Removed redundant changes from Fastlane.swift;
  • Fixed code style.

Copy link
Member

@rogerluan rogerluan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Thanks for all the changes 🚀

fastlane_core/lib/fastlane_core/project.rb Outdated Show resolved Hide resolved
@balavor
Copy link
Contributor Author

balavor commented Jan 14, 2021

@rogerluan is it ready to be merged? :)

@rogerluan
Copy link
Member

It still needs a final ✅ from @joshdholtz, @RomanTysiachnik 🙇 thanks for your understanding 🙏

Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me! Really appreciate the contribution ❤️

@joshdholtz joshdholtz merged commit 97c4723 into fastlane:master Jan 15, 2021
@fastlane-bot
Copy link

Hey @RomanTysiachnik 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

Copy link

@fastlane-bot fastlane-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations! 🎉 This was released as part of fastlane 2.172.0 🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to skip resolvePackageDependencies step
5 participants