Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

update PULL_REQUEST_TEMPLATE's sample issue to a fake issue number #17934

Merged
merged 1 commit into from
Jan 21, 2021

Conversation

rogerluan
Copy link
Member

Motivation and Context

Check out what happened here 馃槄 #1337

image

Description

This is because, even when #1337 is commented out in the PR's descriptions (from the template), fastlane bot still picks it up 馃槄 I figured that simply changing the template was a lot easier than updating the bot's behavior to take markdown comments into consideration 馃檱

Testing Steps

N/A

@google-cla google-cla bot added the cla: yes label Jan 9, 2021
Copy link
Contributor

@ainame ainame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃槄 馃憤

Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha omg 馃ぃ This makes a lot of sense! Thanks for fixing 鉂わ笍

@joshdholtz joshdholtz merged commit f0385a6 into master Jan 21, 2021
@joshdholtz joshdholtz deleted the rogerluan-update-pull-request-template branch January 21, 2021 00:36
Copy link

@fastlane-bot fastlane-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations! 馃帀 This was released as part of fastlane 2.172.0 馃殌

@fastlane fastlane locked and limited conversation to collaborators Mar 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants