[spaceship][docs] update spaceship app store connect docs #17938
Conversation
|
Actually I'm not sure whether the "not working" part should be removed. Looks like it doesn't work with ASC, but the same function does work with regular authentication credentials apparently? 🤔 Also, I think that featuring something in the documentation that is not supported yet may bring even more confusion 😬 |
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
@googlebot I consent. |
| @@ -60,11 +60,11 @@ Spaceship::ConnectAPI::App.all.collect do |app| | |||
| end | |||
|
|
|||
| # Create a new app | |||
| // Not working yet | |||
| # Currently only works with Apple ID login (not API Key) | |||
There was a problem hiding this comment.
Cheers! 🎉 much more clear now!
There was a problem hiding this comment.
Congratulations! 🎉 This was released as part of fastlane 2.172.0 🚀
Motivation and Context
This was exposed as an issue here: #17879 (comment)
Description
Simple docs updating. Removed a comment that said that something was not working (but it is), and update param name.