[scan] fix scan not failing when disable_xcpretty and fail_build are true

[jhandguy]

Checklist

• I've run bundle exec rspec from the root directory to see all new and existing tests pass
• I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
• I've read the Contribution Guidelines
• I've updated the documentation if necessary.

Motivation and Context

Resolves #17945.

Description

In handle_results, if disable_xcpretty is true, then throw a test_failure.
If fail_build is false, the manager will catch the exception and make scan succeed.
If fail_build is true, the manager will throw the exception further and make scan fail.

Testing Steps

Tested locally with a failing test:

• if disable_xcpretty and fail_build are true, scan fails
• if disable_xcpretty is true and fail_build is false, scan does not fail

[joshdholtz]

This makes sense to me! Thank you so much for this fix ❤️ Really appreciate all your contributions!

[fastlane-bot]

Hey @jhandguy 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

[fastlane-bot]

Congratulations! 🎉 This was released as part of fastlane 2.172.0 🚀