Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frameit] fix the screenshot size of iPhone 8 Plus #17977

Merged
merged 1 commit into from
Jan 20, 2021

Conversation

yunhao
Copy link
Contributor

@yunhao yunhao commented Jan 15, 2021

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

#17976

Description

In the previous version of fastlane, frameit can not frame a iPhone 8 Plus screenshot. Because the correct image size is 1242 x 2208, which is incorrectly specified as 1080 x 1920.

Testing Steps

@google-cla
Copy link

google-cla bot commented Jan 15, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Jan 15, 2021
@yunhao
Copy link
Contributor Author

yunhao commented Jan 15, 2021

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Jan 15, 2021
@ainame ainame self-requested a review January 19, 2021 15:04
Copy link
Contributor

@ainame ainame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

I'm just curious about how you got the error you mentioned in the original issue but this PR just looks right.
#17976 (comment)

Thank you and congrats your first-time contribution! 🎉
@joshdholtz will then double-check and merge this when he can 🙇

Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Thanks for fixing this 😊

@joshdholtz joshdholtz merged commit 0c53efb into fastlane:master Jan 20, 2021
Copy link

@fastlane-bot fastlane-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations! 🎉 This was released as part of fastlane 2.172.0 🚀

@fastlane fastlane locked and limited conversation to collaborators Mar 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants