Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pilot] also wait for build processing when only distributing #18073

Merged
merged 5 commits into from
Feb 24, 2021
Merged

[pilot] also wait for build processing when only distributing #18073

merged 5 commits into from
Feb 24, 2021

Conversation

Cyberbeni
Copy link
Contributor

@Cyberbeni Cyberbeni commented Jan 29, 2021

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

Resolves #18072

Description

I'm already on my personal machine, so I couldn't test it and I'll be AFK for a week. I don't usually use ruby, so the syntax might need fixing but the general idea should be correct.

Testing Steps

First only upload the ipa with fastlane pilot (skip waiting for processing and don't set changelog)
fastlane pilot distribute_only

@google-cla google-cla bot added the cla: yes label Jan 29, 2021
@Cyberbeni Cyberbeni changed the title also wait for build processing when only distributing [pilot] also wait for build processing when only distributing Jan 29, 2021
@Cyberbeni
Copy link
Contributor Author

Could probably use some additional automated tests. I've tested the use case in the linked issue.

@google-cla
Copy link

google-cla bot commented Feb 24, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no and removed cla: yes labels Feb 24, 2021
@joshdholtz
Copy link
Member

@googlebot I consent.

@google-cla google-cla bot added cla: yes and removed cla: no labels Feb 24, 2021
Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for making this change! I added tests on this so we should be good to go now 😊 Really appreciate the contribution ❤️

@joshdholtz joshdholtz merged commit c1b3086 into fastlane:master Feb 24, 2021
@fastlane-bot
Copy link

Hey @Cyberbeni 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

Copy link

@fastlane-bot fastlane-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations! 🎉 This was released as part of fastlane 2.176.0 🚀

@fastlane fastlane locked and limited conversation to collaborators Apr 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[pilot] distribute_only doesn't wait for build processing
3 participants