-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fastlane.Swift] Fix Fastfile.swift template syntax error #18589
[Fastlane.Swift] Fix Fastfile.swift template syntax error #18589
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
It'd be great to run the remaining steps before a formal review 🙌 |
I've run the remaining steps! 🙆 |
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
@googlebot I consent. |
@martinolee Thanks so much for making this PR! Your change was a good change 😊 I had no idea that order was messed up. I also took the liberty to add a commit that swapped out using Would you mind checking out my change to make sure that still works for you? 😊 |
98188e0
to
8bd8593
Compare
8bd8593
to
89b8de9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going to merge this in today! Thank you for making this fix for us ❤️ Really appreciate it!
Hey @martinolee 👋 Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉 Please let us know if this change requires an immediate release by adding a comment here 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations! 🎉 This was released as part of fastlane 2.185.1 🚀
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validMotivation and Context
While I was applying fastlane to project I faced issue that default Fastfile.swift template has syntax error.
I noticed this syntax error occurred when I select option not to upload metadata to App Store Connect.
My goal with this PR is to resolve syntax error in Fastfile.swift template.
Description
app
argument ofuploadToAppStore
method to be placed at the end in default swift Fastfile template.