Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fastlane.Swift] Fix Fastfile.swift template syntax error #18589

Merged

Conversation

martinolee
Copy link
Contributor

@martinolee martinolee commented Apr 22, 2021

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

While I was applying fastlane to project I faced issue that default Fastfile.swift template has syntax error.
I noticed this syntax error occurred when I select option not to upload metadata to App Store Connect.

My goal with this PR is to resolve syntax error in Fastfile.swift template.

Description

  • Replaced app argument of uploadToAppStore method to be placed at the end in default swift Fastfile template.

@google-cla
Copy link

google-cla bot commented Apr 22, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Apr 22, 2021
@martinolee
Copy link
Contributor Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Apr 22, 2021
@martinolee martinolee changed the title [Fastlane.Swift] Fix Fastfile.swift template synctax error [Fastlane.Swift] Fix Fastfile.swift template syntax error Apr 22, 2021
@minuscorp
Copy link
Collaborator

It'd be great to run the remaining steps before a formal review 🙌

@martinolee
Copy link
Contributor Author

I've run the remaining steps! 🙆

@google-cla
Copy link

google-cla bot commented May 5, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no and removed cla: yes labels May 5, 2021
@joshdholtz
Copy link
Member

@googlebot I consent.

@google-cla google-cla bot added cla: yes and removed cla: no labels May 5, 2021
@joshdholtz
Copy link
Member

@martinolee Thanks so much for making this PR! Your change was a good change 😊 I had no idea that order was messed up. I also took the liberty to add a commit that swapped out using app or app_identifier since that one is technically more correct 😇

Would you mind checking out my change to make sure that still works for you? 😊

@joshdholtz joshdholtz force-pushed the fix-swift-fastfile-template-syntax-error branch from 8bd8593 to 89b8de9 Compare June 11, 2021 19:44
Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to merge this in today! Thank you for making this fix for us ❤️ Really appreciate it!

@joshdholtz joshdholtz merged commit 248a9d5 into fastlane:master Jun 11, 2021
@fastlane-bot
Copy link

Hey @martinolee 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

Copy link

@fastlane-bot fastlane-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations! 🎉 This was released as part of fastlane 2.185.1 🚀

@fastlane fastlane locked and limited conversation to collaborators Aug 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants