Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gym] improved provisioning export with odd names in specs #18741

Merged

Conversation

hfehrmann
Copy link
Contributor

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

Gym provisioning profile resolution for exporting the ipa when detecting profiles from project is not clear in the documentation.

Description

Gym detects by default the provisioning profiles. The documentation states that it is possible to define the export provisioning profiles. However, the actual resolution is consistent with the specs of CodeSigningMapping. This MR only clarifies the spec for the mapping.

@google-cla
Copy link

google-cla bot commented May 22, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label May 22, 2021
@hfehrmann
Copy link
Contributor Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels May 22, 2021
@joshdholtz joshdholtz changed the title Gym provisioning export with odd names [gym] improved provisioning export with odd names in specs May 28, 2021
Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These PRs are some of my favorite 😊 Your changes make it much clearer with what is being tested! Thank you ❤️ Appreciate the contribution!

@joshdholtz joshdholtz merged commit 9d39044 into fastlane:master May 28, 2021
@hfehrmann
Copy link
Contributor Author

@joshdholtz I'm glad you liked it 😁. I also want to change the documentation for the specific part of provisioning profile export, but I don't know where to do it. I had some problemas with how things work, because the name of my profiles are "non-standard", and gym behaved weird from my perspective. That behavior lead to improve this part of the spec, which actually behaves as expected per the spec, but it is not clear to the final user.

@fastlane-bot
Copy link

Hey @hfehrmann 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.184.1 🚀

@fastlane fastlane locked and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants