New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gym] improved provisioning export with odd names in specs #18741
[gym] improved provisioning export with odd names in specs #18741
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These PRs are some of my favorite 😊 Your changes make it much clearer with what is being tested! Thank you ❤️ Appreciate the contribution!
@joshdholtz I'm glad you liked it 😁. I also want to change the documentation for the specific part of provisioning profile export, but I don't know where to do it. I had some problemas with how things work, because the name of my profiles are "non-standard", and gym behaved weird from my perspective. That behavior lead to improve this part of the spec, which actually behaves as expected per the spec, but it is not clear to the final user. |
Hey @hfehrmann 👋 Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉 Please let us know if this change requires an immediate release by adding a comment here 👍 |
Congratulations! 🎉 This was released as part of fastlane 2.184.1 🚀 |
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validMotivation and Context
Gym provisioning profile resolution for exporting the ipa when detecting profiles from project is not clear in the documentation.
Description
Gym detects by default the provisioning profiles. The documentation states that it is possible to define the export provisioning profiles. However, the actual resolution is consistent with the specs of
CodeSigningMapping
. This MR only clarifies the spec for the mapping.