Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fastlane_core] [env] Add Swift version to fastlane env #18772

Merged
merged 1 commit into from
Jun 2, 2021

Conversation

minuscorp
Copy link
Collaborator

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

It is good to know beforehand the Swift version used when a Fastlane.Swift and other issues may arise instead of having to ask the user for it.

Description

I've added a new row with the swift version (only the version code) to the fastlane env command.

Testing Steps

  1. Checkout this branch and install it
  2. Run fastlane env
  3. 馃殌

Copy link
Member

@crazymanish crazymanish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested! It's working on my mac! 馃帀
Screenshot 2021-05-29 at 17 23 47

Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this! Kinda embarrassed we didn鈥檛 have this earlier 馃槢 But thank you!

@joshdholtz joshdholtz merged commit adc0af3 into fastlane:master Jun 2, 2021
@fastlane-bot
Copy link

Hey @minuscorp 馃憢

Thank you for your contribution to fastlane and congrats on getting this pull request merged 馃帀
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 馃憤
We'll notify you once we shipped a new release with your changes 馃殌

@fastlane-bot
Copy link

Congratulations! 馃帀 This was released as part of fastlane 2.185.0 馃殌

@fastlane fastlane locked and limited conversation to collaborators Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants