Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pilot] Improve the Pilot::Manager unit tests #18777

Merged
merged 2 commits into from
Jun 1, 2021

Conversation

crazymanish
Copy link
Member

@crazymanish crazymanish commented May 30, 2021

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

  • I was working on one pilot bug-fix and notice that Pilot::Manager unit tests required some improvements.
    (I will be adding more unit-tests soon)

In this PR

  • Added Pilot::Manager #start unit tests
  • Added Pilot::Manager #login unit tests

Testing Steps

  • Checkout this PR and
  • Run bundle exec rspec pilot/spec/manager_spec.rb

Screenshot

Screenshot 2021-05-30 at 14 29 37 2

@google-cla google-cla bot added the cla: yes label May 30, 2021
Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is sooooooo much better! I also had no idea about shared_examples or it_behaves_like 🤯 Always something new!

@joshdholtz joshdholtz merged commit a553f89 into master Jun 1, 2021
@joshdholtz joshdholtz deleted the crazymanish-pilot-manager-unit-tests branch June 1, 2021 21:08
@fastlane-bot
Copy link

Hey @crazymanish 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.185.0 🚀

@fastlane fastlane locked and limited conversation to collaborators Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants