Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fastlane_core] add pods project schemes environment variable #18815

Merged
merged 1 commit into from
Jun 8, 2021
Merged

[fastlane_core] add pods project schemes environment variable #18815

merged 1 commit into from
Jun 8, 2021

Conversation

tejassharma96
Copy link
Contributor

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

At my workplace for one of our projects, we run a test spec from one of our internal cocoapods as a smoke test before running lengthier UI tests that depend on that pod. I was able to use the cocoapods post_install block to make the scheme public when installing on CI, but we're still unable to run those tests on fastlane since fastlane filters out pods schemes.

Description

I added an environment variable to optionally disable the filtering out of environment variables.
I tested this out by verifying that the scheme could be found with the environment set to a truthy value, and it could not be found when the environment variable is unset or set to a falsy value.

@google-cla
Copy link

google-cla bot commented Jun 7, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Jun 7, 2021
@tejassharma96
Copy link
Contributor Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Jun 7, 2021
@google-cla
Copy link

google-cla bot commented Jun 7, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no and removed cla: yes labels Jun 7, 2021
Add an environment variable to control whether pods project schemes are visible to fastlane actions.
@google-cla google-cla bot added cla: yes and removed cla: no labels Jun 7, 2021
@joshdholtz joshdholtz changed the title Add pods project schemes environment variable [fastlane_core] add pods project schemes environment variable Jun 8, 2021
Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me! Sorry if this caused any issues but thank you for fixing 😊

@joshdholtz joshdholtz merged commit 57d2851 into fastlane:master Jun 8, 2021
@tejassharma96
Copy link
Contributor Author

Thanks for the quick merge!

@fastlane-bot
Copy link

Hey @tejassharma96 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.185.1 🚀

@fastlane fastlane locked and limited conversation to collaborators Aug 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants