-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[snapshot] Allow iPods to run alongside iPhone and iPad #18843
[snapshot] Allow iPods to run alongside iPhone and iPad #18843
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤯 I am really surprised this wasn’t in here already! Thank you so much for adding this in ❤️
Hey @mdubs 👋 Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉 Please let us know if this change requires an immediate release by adding a comment here 👍 |
Congratulations! 🎉 This was released as part of fastlane 2.185.1 🚀 |
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validMotivation and Context
Resolves #18842
Allows iPod touch device to run snapshot in parallel with iPhone and iPad devices
Description
This allows the device to start with ipod as well as iphone and iPad as they are all I(Pad)OS devices. I added unit tests for having iPods in conjunction with other device types
Testing Steps
Ran the full test suite for fastlane as well as ran my screenshots using the changed fastlane using iPod touch 7th Gen and iPhone 12 simulators