Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[snapshot] Allow iPods to run alongside iPhone and iPad #18843

Merged

Conversation

mdubs
Copy link
Contributor

@mdubs mdubs commented Jun 9, 2021

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

Resolves #18842
Allows iPod touch device to run snapshot in parallel with iPhone and iPad devices

Description

This allows the device to start with ipod as well as iphone and iPad as they are all I(Pad)OS devices. I added unit tests for having iPods in conjunction with other device types

Testing Steps

Ran the full test suite for fastlane as well as ran my screenshots using the changed fastlane using iPod touch 7th Gen and iPhone 12 simulators

@google-cla
Copy link

google-cla bot commented Jun 9, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Jun 9, 2021
@mdubs
Copy link
Contributor Author

mdubs commented Jun 9, 2021

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Jun 9, 2021
Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤯 I am really surprised this wasn’t in here already! Thank you so much for adding this in ❤️

@joshdholtz joshdholtz merged commit 3e186ee into fastlane:master Jun 9, 2021
@fastlane-bot
Copy link

Hey @mdubs 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.185.1 🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants